Skip to content

Conversation

@arora-r
Copy link
Member

@arora-r arora-r commented Oct 1, 2025

PR Description

Simplify assignment export logic so we dont need to add every value individually to the export. Makes it easier to expand the logic in the future so that if new fields are added to the assignment config, it can be added easily.

Overview:

Switch logic to take everything from the assignment config and just omit fields we define.

Type of Issue:

  • Feature (feat): New functionality or feature added.
  • Bug Fix (bug): Issue or bug resolved.
  • Chore (chore): Maintenance, refactoring, or non-functional changes.
  • Documentation Update (doc): Documentation improvements or additions.

Change Type:

  • Major: Significant changes that introduce new features, large refactoring, or breaking changes. Requires thorough review and testing.
  • Minor: Small to medium changes, such as adding new functionality that is backward-compatible or minor refactoring. Moderate review needed.
  • Patch: Bug fixes, small tweaks, or documentation updates. Light review is sufficient.

Testing & Validation:

  • Unit Tests: Added/updated to cover new logic or edge cases.
  • Integration Tests: Updated to verify interactions between components.
  • E2E Tests: Performed end-to-end testing in staging or development environment.
  • Manual Testing: The changes were manually tested and validated.
  • No Regressions: Verified that no existing functionality is broken.

Purpose:

Context:

Basic Usage:

Notes to Reviewer:

@arora-r arora-r requested a review from MmagdyHafezZ as a code owner October 1, 2025 17:02
Base automatically changed from feat/include-cooldown-periods to master October 9, 2025 10:27
@MmagdyHafezZ MmagdyHafezZ merged commit 74d3bd9 into master Oct 9, 2025
10 checks passed
@MmagdyHafezZ MmagdyHafezZ deleted the chore/improve-export branch October 9, 2025 10:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants