Skip to content

Fix get_table_comment return value#135

Merged
bchoudhary6415 merged 1 commit intoibmdb:masterfrom
andrasore-kodinfo:master
Jul 4, 2023
Merged

Fix get_table_comment return value#135
bchoudhary6415 merged 1 commit intoibmdb:masterfrom
andrasore-kodinfo:master

Conversation

@andrasore-kodinfo
Copy link
Copy Markdown
Contributor

No description provided.

@bchoudhary6415
Copy link
Copy Markdown
Collaborator

bchoudhary6415 commented Jun 28, 2023

@andrasore-kodinfo
Thanks for raising pull request.
It will be great help if you can explain for which issue you have raised PR.
If you can share some sample repo regarding this issue.

Thanks

Signed-off-by: Andras Sore <sore.andras@kodinformatika.hu>
@andrasore-kodinfo
Copy link
Copy Markdown
Contributor Author

andrasore-kodinfo commented Jun 28, 2023

@bchoudhary6415
This fixes apache/superset#24130.
Superset is calling get_table_comment while getting metadata for it's database tables. However, since ibm_db_sa is returning an SQLAlchemy cursor object instead of a string, the result cannot be serialized to JSON and the request crashes on Superset's backend.
I've fixed get_table_comment so it would return a string value instead.

@bchoudhary6415 bchoudhary6415 merged commit 2a0fe78 into ibmdb:master Jul 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants