Conversation
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
There was a problem hiding this comment.
Sorry @mshriver, your pull request is larger than the review limit of 150000 diff characters
There was a problem hiding this comment.
Pull request overview
This PR adds comprehensive frontend test coverage for React components and pages, improves backend test organization by consolidating imports, and provides detailed testing documentation. The changes follow integration testing best practices with minimal mocking.
Key changes:
- Added 11 new frontend test files covering widgets, pages, and components
- Enhanced test utilities with new helpers and mock data factories
- Created comprehensive testing guide documentation
- Refactored backend tests to consolidate imports at file level
- Added backend utility function test coverage
Reviewed changes
Copilot reviewed 35 out of 35 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
frontend/src/widgets/run-aggregate-apex.test.js |
New comprehensive tests for RunAggregateApex widget |
frontend/src/widgets/result-aggregate-apex.test.js |
New tests for ResultAggregateApex widget |
frontend/src/widgets/filter-heatmap.test.js |
Added 557 lines of new test coverage for cell rendering, Jenkins links, and edge cases |
frontend/src/pages/result-list.test.js |
Updated parameter types from number to string for URL params |
frontend/src/pages/login.test.js |
New comprehensive login page tests covering OAuth and form validation |
frontend/src/pages/dashboard.test.js |
Added tests for dashboard selection, CRUD operations, and widget management |
frontend/src/pages/admin/project-edit.test.js |
New tests for project editing admin page |
frontend/src/components/test-history.test.js |
New tests for test history table component |
frontend/src/components/ibutsu-header.test.js |
New tests for header component with project selection |
frontend/src/components/filtering/result-filter.test.js |
Added 277 lines of tests for various filter operations |
frontend/src/components/classify-failures.test.js |
New tests for failure classification component |
frontend/src/test-utils/test-helpers.js |
Added new helper functions for rendering with providers and mocking HTTP responses |
frontend/src/test-utils/mock-data.js |
Added factory functions for Jenkins runs and nested metadata |
frontend/src/test-utils/constants.js |
Added Jenkins and nested metadata test constants |
docs/source/developer-guide/frontend-testing.rst |
Replaced placeholder with comprehensive 569-line testing guide |
backend/tests/test_*.py |
Multiple files refactored to consolidate imports at module level |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
mshriver
force-pushed
the
frontend-test-coverage
branch
from
28f8b31 to
03c80d4
Compare
mshriver
force-pushed
the
frontend-test-coverage
branch
from
03aeb0b to
fc37a83
Compare
Codecov Report❌ Patch coverage is
❌ Your patch status has failed because the patch coverage (74.19%) is below the target coverage (85.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## main #792 +/- ##
==========================================
+ Coverage 64.81% 73.40% +8.59%
==========================================
Files 157 154 -3
Lines 7633 7557 -76
Branches 659 660 +1
==========================================
+ Hits 4947 5547 +600
+ Misses 2467 1790 -677
- Partials 219 220 +1
... and 7 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
mshriver
force-pushed
the
frontend-test-coverage
branch
from
fc37a83 to
404aa90
Compare
Use data-ouia-component-id directly where necessary for testing small bug fixes with button state for project edit Adjust backend conftest for github CI
mshriver
force-pushed
the
frontend-test-coverage
branch
from
404aa90 to
7774d0d
Compare
sqlalchemy and redis local configs
Small updates across the tests to resolve warnings.
Console.error -> warning pattern suppressed in tests that expect errors so no warnings are displayed in the outcome of the test run when things are passing.
Adding ouiaId where applicable, removing anywhere that it was previously added but isn't actually supported.