Conversation
There was a problem hiding this comment.
Pull request overview
This PR refactors the search functionality by removing unused fallback mechanisms and simplifying the search implementation. The changes align with the stated goal of separating rendering concerns and removing code paths that were never executed.
Key Changes:
- Removed unused fallback search methods (
searchViaDatabaseQueryandmatchesQuery) that were never called - Simplified error handling for tag generation in
SaveEntry, treating tags as truly optional - Updated documentation to reflect the streamlined search approach
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
Addresses feedback on PR #69 where tag generation errors were silently ignored, making AI service failures invisible to operators. **Changes:** - Restored `log.Printf` when tag generation fails, including entry text length for debugging context - Maintained "tags are optional" behavior - errors logged but don't block entry creation ```go if tagRes.err != nil { // Log error but continue - tags are optional log.Printf("could not generate tags for entry (%d chars): %s", len(text), tagRes.err) tagRes.tags = []string{} } ``` <!-- START COPILOT CODING AGENT TIPS --> --- ✨ Let Copilot coding agent [set things up for you](https://github.com/icco/etu/issues/new?title=✨+Set+up+Copilot+instructions&body=Configure%20instructions%20for%20this%20repository%20as%20documented%20in%20%5BBest%20practices%20for%20Copilot%20coding%20agent%20in%20your%20repository%5D%28https://gh.io/copilot-coding-agent-tips%29%2E%0A%0A%3COnboard%20this%20repo%3E&assignees=copilot) — coding agent works faster and does higher quality work when set up for your repo. --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: icco <20201+icco@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.