Treat missing timesince cache as cache miss, not error#94
Merged
Conversation
On first use, the cache file doesn't exist yet. Instead of logging a confusing error, cacheFromFile() now returns (nil, nil) for a missing file, allowing TimeSinceLastPost() to proceed and create the cache. Agent-Logs-Url: https://github.com/icco/etu/sessions/acb3f2f1-e81c-46e6-96e9-49f0c4364e63 Co-authored-by: icco <20201+icco@users.noreply.github.com>
icco
approved these changes
Apr 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
First-time
etuCLI usage logs a confusing error becausecacheFromFile()treats a nonexistent cache file as an error rather than a cache miss.cacheFromFile()now returns(nil, nil)onos.IsNotExist, lettingTimeSinceLastPostfall through toUpdateCachewhich creates the directory and file viaMkdirAllTestCacheFromFileMissingto assert no error on missing file