fix: use webpack progress plugin when it is not tty #22
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
eslint 处理一下 |
chenbin92
reviewed
Jul 17, 2019
| .end() | ||
| .plugin('SimpleProgressPlugin') | ||
| .use(SimpleProgressPlugin) | ||
| .use(!process.stderr.isTTY ? ProgressPlugin : SimpleProgressPlugin) |
There was a problem hiding this comment.
这是内置了这个能力？都不需要自己 console.log 了？
There was a problem hiding this comment.
直接输出了webpack的默认信息，https://github.com/webpack/webpack/blob/master/lib/ProgressPlugin.js#L66
There was a problem hiding this comment.
这是内置了这个能力？都不需要自己 console.log 了？
嗯 内置的输出信息比较全面
imsobear
approved these changes
Jul 17, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.