Skip to content

fix: use webpack progress plugin when it is not tty #22

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 17, 2019
Merged

fix: use webpack progress plugin when it is not tty #22

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0d2a915
fix: use webpack progress plugin when it is not tty
ClarkXia Jul 17, 2019
3141cce
chore: add comment
ClarkXia Jul 17, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion packages/ice-scripts/lib/config/setWebpackPlugins.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@ const webpack = require('webpack');
const MiniCssExtractPlugin = require('mini-css-extract-plugin');
const FilterWarningsPlugin = require('webpack-filter-warnings-plugin');
const SimpleProgressPlugin = require('webpack-simple-progress-plugin');
const ProgressPlugin = require('webpack/lib/ProgressPlugin');
const HtmlWebpackPlugin = require('html-webpack-plugin');
const CopyWebpackPlugin = require('copy-webpack-plugin');
const CaseSensitivePathsPlugin = require('case-sensitive-paths-webpack-plugin');
Expand All @@ -29,7 +30,8 @@ module.exports = (chainConfig, mode = 'development') => {
}])
.end()
.plugin('SimpleProgressPlugin')
.use(SimpleProgressPlugin)
// SimpleProgressPlugin will not write webpack info to stderr when it is not tty
.use(!process.stderr.isTTY ? ProgressPlugin : SimpleProgressPlugin)
Copy link
Contributor

@chenbin92 chenbin92 Jul 17, 2019 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

可以考虑加个 Notes 说明下

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这是内置了这个能力？都不需要自己 console.log 了？

Copy link
Contributor

@chenbin92 chenbin92 Jul 17, 2019 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

直接输出了webpack的默认信息，https://github.com/webpack/webpack/blob/master/lib/ProgressPlugin.js#L66

image

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这是内置了这个能力？都不需要自己 console.log 了？

嗯 内置的输出信息比较全面

.end()
.plugin('CaseSensitivePathsPlugin')
.use(CaseSensitivePathsPlugin)
Expand Down