This repository was archived by the owner on May 9, 2020. It is now read-only.
Feat/enhance request #161
Merged
Feat/enhance request #161
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@ClarkXia 主要思路是把 module.ts => module.ts.ejs，然后区分 staticModule 和 runtimeModule 的调用时机 |
chenbin92
commented
Mar 26, 2020
packages/plugin-core/src/index.ts
Outdated
| const rendererContent = ejs.render(moduleContent); | ||
| const pkgPath = path.join(pluginPath, '../../package.json'); | ||
| const { moduleConfig } = fse.readJSONSync(pkgPath); | ||
| const moduleFolderName = moduleConfig && moduleConfig.folderName ? moduleConfig.folderName : 'module'; |
Contributor
Author
There was a problem hiding this comment.
这里需要看下是在 package.json 中约定导出的文件名还是都导出到 module 目录下
Contributor
|
可以验证下 request module 加载提前的情况下，是不是可以达到类似的效果。 |
ClarkXia
approved these changes
Mar 27, 2020
imsobear
added a commit
that referenced
this pull request
Mar 27, 2020
chenbin92
pushed a commit
that referenced
this pull request
Mar 30, 2020
* chore: release version * fix: semicolons is required (#162) * chore: fallback example (#169) * fix: onHook position (#173) * chore: version * v1.1.3-alpha.0 * fix: pass location params to StaticRouter (#176) * fix: pass location params * fix: context params * chore: code optimization * fix: pass staticRouter context * Feat/enhance request (#161) * feat: enhance request * refactor: load module time (#174) * refactor: load module Co-authored-by: ClarkXia <xiawenwu41@gmail.com> * feat: downgraded to csr when ssr error (#179) * fix: define process.env.APP_MODE in ssr (#181) * fix: define process.env.APP_MODE in ssr * fix: modify define plugin Co-authored-by: 大果 <sobear.me@gmail.com> * fix: publish script (#180) * v1.1.3-alpha.1 * fix: ssr to csr (#182) * fix: use window variable * chore: typo * fix: remove define variables * refactor: server render * v1.1.3-alpha.2 * chore: fix lint (#183) * chore: update example * fix: params * chore: revert beforeload (#185) * Revert "Feat/enhance request (#161)" This reverts commit 0ceed05. * v1.1.3-alpha.3 * feat: support runtime app_mode (#189) * feat: support runtime app_mode * feat: support process.env.SERVER_PORT * fix: lock core-js version (#184) * fix: lint error (#190) * feat: add static module (#188) * fix: set polyfill * fix: before load module * fix: load module in createApp * chore: rename variable * feat: support uglify * refactor: code optim * fix: window is not defined (#193) * v1.1.3-alpha.4 * v1.1.3
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix issue: #122