fix: codex models return 404 when upstream providers are configured#369
Merged
icebear0828 merged 2 commits intomasterfrom Apr 13, 2026
Merged
fix: codex models return 404 when upstream providers are configured#369icebear0828 merged 2 commits intomasterfrom
icebear0828 merged 2 commits intomasterfrom
Conversation
The `resolveMatch()` fallback required `defaultAdapter?.tag === "codex"`, but the adapters map never contains a "codex" key — only configured provider names (openai, anthropic, etc.). This caused all codex-native models (gpt-5.4, o3, etc.) to fall through to "not-found". Remove the adapter tag check: `isKnownCodexModel()` alone is sufficient since codex models route to the built-in chatgpt.com backend and don't need an adapter. Fixes #368
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
UpstreamRouter.resolveMatch()incorrectly returningnot-foundfor codex-native models (gpt-5.4, o3, etc.) when any upstream provider is configureddefaultAdapter?.tag === "codex"always failing because the adapters map never contains a"codex"keykind: "codex"adapter optional since codex models route to the built-in chatgpt.com backendFixes #368
Test plan
upstream-router.test.ts— 14 tests pass (codex routing no longer depends on adapter tag)upstream-router-apikeys.test.ts— 10 tests pass (API key pool routing unaffected)