Enhancement: empty property added to url rule
#150
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gamote
changed the title
url ruleurl rule
…into feature/url-empty-and-optional
icebob
reviewed
Jun 10, 2020
Contributor
Author
|
@icebob Can you review the changes? |
erfanium
requested changes
Jun 11, 2020
Collaborator
erfanium
approved these changes
Jun 11, 2020
icebob
approved these changes
Jun 12, 2020
Owner
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
emptyproperty was added to theurlrule (#116)What was done:
url.js