feat(uuid): support uuid v6 #181
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
feat(uuid): support uuid v6
feat(uuid): support uuid v6
erfanium
requested changes
Jul 31, 2020
Collaborator
erfanium
left a comment
erfanium
left a comment
There was a problem hiding this comment.
Great, But please add a test for this feature
feat(uuid): support uuid v6
Contributor
Author
|
@erfanium done |
Owner
|
@intech something happened after I merged. CI test failed: https://github.com/icebob/fastest-validator/runs/941547306?check_suite_focus=true#step:5:37 |
Contributor
Author
|
@intech one moment |
Merged
Contributor
Author
|
@icebob done. Sorry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added support for uuid v6, which is a modified version from uuid v1 with lexicographic order for sorting.
Ref: https://www.npmjs.com/package/uuid-v6