Skip to content

[BugFix] [objectID rule] validator throws error when convert: true #183

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
erfanium merged 1 commit into from
Aug 10, 2020
Merged

[BugFix] [objectID rule] validator throws error when convert: true #183

erfanium merged 1 commit into from
Aug 10, 2020

Conversation

@erfanium
Copy link
Collaborator

@erfanium erfanium commented Aug 10, 2020 •
edited
Loading

No description provided.

@erfanium erfanium added the bug label Aug 10, 2020
@erfanium erfanium requested a review from icebob August 10, 2020 21:55
@erfanium erfanium changed the title [BugFix] validator throws error when convert: true [BugFix] [objectID rule] validator throws error when convert: true Aug 10, 2020
@coveralls
Copy link

coveralls commented Aug 10, 2020

Coverage Status

Coverage remained the same at 99.579% when pulling 6a42d0d on erfanium:objectID-bug-fix into 17e034d on icebob:master.

@erfanium
Copy link
Collaborator Author

erfanium commented Aug 10, 2020 •
edited
Loading

@icebob
Because this bug is important but easy to fix, I'll merge these changes now without code review. Feel free to update/revert these changes if there's a problem

@erfanium erfanium merged commit 5cb943a into icebob:master Aug 10, 2020
@erfanium erfanium deleted the objectID-bug-fix branch August 10, 2020 22:06
@erfanium
Copy link
Collaborator Author

erfanium commented Aug 10, 2020

@icebob
We may need to release 1.6.1 :-)

@icebob
Copy link
Owner

icebob commented Aug 11, 2020

Ok, but please wait for review in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@icebob icebob Awaiting requested review from icebob

Assignees

No one assigned

Labels

bug

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@erfanium @coveralls @icebob