Skip to content

Update readme #36

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
icebob merged 1 commit into from
Nov 2, 2018
Merged

Update readme #36

icebob merged 1 commit into from
Nov 2, 2018

Conversation

@zmarouf
Copy link
Contributor

@zmarouf zmarouf commented Nov 2, 2018

No description provided.

@zmarouf
Copy link
Contributor Author

zmarouf commented Nov 2, 2018

I did a quick pass. There might still be things to change. I'll check the code to replace larger with greater

@coveralls
Copy link

coveralls commented Nov 2, 2018

Coverage Status

Coverage remained the same at 99.636% when pulling 978bbf0 on zmarouf:patch-1 into ab78b45 on icebob:master.

1 similar comment
@coveralls
Copy link

coveralls commented Nov 2, 2018

Coverage Status

Coverage remained the same at 99.636% when pulling 978bbf0 on zmarouf:patch-1 into ab78b45 on icebob:master.

@coveralls
Copy link

coveralls commented Nov 2, 2018 •
edited
Loading

Coverage Status

Coverage remained the same at 99.636% when pulling 3e83d56 on zmarouf:patch-1 into ab78b45 on icebob:master.

@zmarouf
Copy link
Contributor Author

zmarouf commented Nov 2, 2018

Never used Codacy but is this normal?
image

icebob
icebob approved these changes Nov 2, 2018
View reviewed changes
Copy link
Owner

@icebob icebob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool, thank you!

@icebob icebob merged commit 6d5f208 into icebob:master Nov 2, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@icebob icebob icebob approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@zmarouf @coveralls @icebob