Skip to content

Making "{actual}" property available to custom string validation messages #91

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
icebob merged 2 commits into from
Oct 25, 2019
Merged

Making "{actual}" property available to custom string validation messages #91

icebob merged 2 commits into from
Oct 25, 2019

Conversation

@victal
Copy link
Contributor

@victal victal commented Oct 24, 2019 •
edited
Loading

Using the {actual} placeholder on a custom message for stringEnum and a few other string validations wasn't working (the placeholder was replaced with an empty string) because the actual value was not being passed along to this.makeError.

@coveralls
Copy link

coveralls commented Oct 24, 2019

Coverage Status

Coverage remained the same at 100.0% when pulling 0cac456 on victal:stringEnum-actual-value into 3bc3cae on icebob:master.

icebob
icebob approved these changes Oct 25, 2019
View reviewed changes
Copy link
Owner

@icebob icebob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks!

@icebob icebob merged commit dd3a020 into icebob:master Oct 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@icebob icebob icebob approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@victal @coveralls @icebob