Add CI and toolchain to Protobuf build telemetry#4682
Merged
Conversation
bernardnormier
requested review from
InsertCreativityHere,
Copilot,
externl and
pepone
There was a problem hiding this comment.
Pull request overview
This PR extends the Protobuf build-telemetry reporting pipeline to include (1) whether the build is running under CI and (2) the .NET toolchain version, and wires these values from MSBuild into the telemetry plug-in payload.
Changes:
- Add
toolchain=dotnet:<sdkVersion>andcioptions to the build-telemetry protoc plug-in invocation. - Extend the build-telemetry protobuf schema with
ToolchainInfoand aciflag onTelemetryData. - Refactor the build-telemetry plug-in to parse the new parameters directly into
TelemetryData.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| src/IceRpc.Protobuf.Tools/IceRpc.Protobuf.Tools.targets | Adds toolchain and CI flags to the build-telemetry plug-in parameter string. |
| src/IceRpc.Protobuf.BuildTelemetry/proto/icerpc/protobuf/build_telemetry.proto | Adds toolchain + CI fields (but currently renumbers existing tags). |
| src/IceRpc.Protobuf.BuildTelemetry/Program.cs | Updates parameter parsing to fill TelemetryData with toolchain/CI info. |
pepone
approved these changes
May 21, 2026
externl
approved these changes
May 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4680