Fix Ice TODOs, update docs.zeroc.com references#474
Fix Ice TODOs, update docs.zeroc.com references#474bernardnormier merged 7 commits intoicerpc:csharp-0.6-devfrom
Conversation
There was a problem hiding this comment.
Pull request overview
Updates documentation to resolve remaining Ice-related TODOs and to point external Ice manual references at the Ice 3.8 docs (per #454).
Changes:
- Removed unused link references from Slice encoding docs.
- Updated Ice manual links (and switched to
docs.zeroc.com), including the facet reference and ice protocol references. - Replaced “TODO: ice definitions” placeholders in the ice protocol frames page with concrete Ice IDL examples, and filled in a previously
TODOC# metadata directive link.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| content/slice/encoding/user-defined-types.md | Removes unused reference-style links at the end of the page. |
| content/icerpc/invocation/service-address.md | Updates the external “Ice facet” link to Ice 3.8 docs. |
| content/icerpc/ice-protocol/protocol-frames.md | Replaces TODO placeholders with Ice IDL examples and updates Ice manual reference links to 3.8. |
| content/icerpc-for-ice-users/ice-definitions/struct-types.md | Replaces a TODO reference link for cs:readonly with the Ice 3.8 docs URL. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| Ok = 0, | ||
| UserException, | ||
| ObjectNotExist, | ||
| FacetNotExist, | ||
| OperationNotExist, | ||
| UnknownLocalException, | ||
| UnknownUserException, | ||
| UnknownException, | ||
| InvalidData, |
There was a problem hiding this comment.
The commas are required for the Ice syntax (ice code blocks). They are optional for the Slice syntax (slice code block).
| Request = 0, | ||
| RequestBatch = 1, | ||
| Reply = 2, | ||
| ValidateConnection = 3, | ||
| CloseConnection = 4, |
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
Pull request overview
Updates documentation to remove remaining TODO placeholders in Ice protocol docs and to ensure external references point to the Ice 3.8 documentation (per #454).
Changes:
- Replaced “TODO: ice definitions” placeholders in the IceRPC protocol frames doc with concrete Ice IDL snippets and updated related terminology/tables.
- Updated external doc links from the old doc site/version to
https://docs.zeroc.com/ice/3.8/.... - Removed unused link reference definitions and replaced a remaining TODO link with a real URL.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| content/slice/encoding/user-defined-types.md | Removes unused link reference definitions at the end of the page. |
| content/icerpc/invocation/service-address.md | Updates the external “Ice facet” documentation link to Ice 3.8. |
| content/icerpc/ice-protocol/protocol-frames.md | Fills in missing Ice IDL definitions and updates protocol/doc references to Ice 3.8. |
| content/icerpc-for-ice-users/ice-definitions/struct-types.md | Replaces a TODO reference link for cs:readonly with the corresponding Ice 3.8 docs URL. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
Pull request overview
Updates documentation to remove stale TODOs and refresh external Ice Manual references to the Ice 3.8 docs site, aligning with issue #454.
Changes:
- Replaced/updated external Ice Manual links to
https://docs.zeroc.com/ice/3.8/.... - Filled in previously “TODO: ice definitions” sections with concrete
iceIDL snippets for protocol frames. - Removed unused link references and replaced a TODO link for
cs:readonlywith a real target.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| content/slice/encoding/user-defined-types.md | Removes now-unused reference definitions (including an old Ice 3.7 link). |
| content/icerpc/invocation/service-address.md | Updates the “Ice facet” external documentation link to the Ice 3.8 docs site. |
| content/icerpc/ice-protocol/protocol-frames.md | Replaces TODO placeholders with ice definitions and updates Ice Manual links to 3.8. |
| content/icerpc-for-ice-users/ice-definitions/struct-types.md | Fixes formatting around cs:readonly reference and replaces a TODO link with the Ice 3.8 target. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Fixes #454