Skip to content

Milestone "Resources, Assets and UI"#109

Merged
Dandielo merged 95 commits intomasterfrom
milestone-0501290322
Apr 12, 2022
Merged

Milestone "Resources, Assets and UI"#109
Dandielo merged 95 commits intomasterfrom
milestone-0501290322

Conversation

@Dandielo
Copy link
Copy Markdown
Member

The following issues will be updated:

* We can provide conan_profiles for workspace setup.
* Just make enough to compile.
* Refactored smaller parts of the code.
Dandielo added 13 commits March 29, 2022 18:06
* Also containing few minor changes.
* Co-Existing API to not break compilation, yet.
* Redone how asset types are defined and handled.
* Redone how assets are accessed and tracked.
* Redone how asset data is prepared and loaded.
[skip ci]
* Replaced some places with the new AssetStorage type.
* Compiles but does not run.
* Updated sprite, actor and animator traits.
* Minor changes to the Asset API, more to come.
* The test project is now again matching the master branch version.
@Dandielo
Copy link
Copy Markdown
Member Author

Dandielo commented Apr 10, 2022

closes #62

@Dandielo Dandielo linked an issue Apr 10, 2022 that may be closed by this pull request
@Dandielo Dandielo marked this pull request as ready for review April 10, 2022 23:18
@Dandielo
Copy link
Copy Markdown
Member Author

Final fixes for unix are required. But the milestone is wrapped up for the Resource and Asset API refactors.

Additional work will be built uppon it.

Comment thread source/code/core/core/public/ice/base.hxx
Comment thread source/code/core/core/public/ice/os/windows.hxx
Comment thread source/code/core/tasks/private/task_thread_v2.cxx
Comment thread source/code/core/utils/public/ice/log.hxx
Comment thread source/code/core/utils/public/ice/userdata.hxx
Comment thread source/code/iceshard/application/private/application.cxx
Copy link
Copy Markdown
Member Author

@Dandielo Dandielo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checked. Remaining thing is to address conversations and create new tasks / issues.

@Dandielo Dandielo merged commit fb385bd into master Apr 12, 2022
@Dandielo Dandielo deleted the milestone-0501290322 branch April 24, 2022 23:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement Improvements or additions to code feature Request for a new feature or functionality tech-debt Technical debt that needs to be addressed, but can be tolerated for some time

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

Milestone (5th Jan -> 29 Mar) - "Assets, Resources and UI" Asset system refactor. Resource system refactor.

1 participant