ci: restore aws-lc-rs crypto provider, use cargo-c for librustls install #5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The workflow is using the latest cargo-c release, not one tailored to a Minimum Supported Rust Version (MSRV).
cmake is only required for the client/server example binaries. For mod_tls we only need the librustls bits and can use cargo-c directly. cargo-c respects the host OS pattern of putting libs in an arch-specific subdir. To make the older 0.14.x Makefile install and the cargo-c install equivalent we override this behaviour by setting --libdir.
This works without issue with the main branch of rustls-ffi. For the 0.14.1 release when using the Makefile to install there's an upstream issue where the CFLAGS intended for the rustls-ffi client/server examples are _also_ used when building librustls and its rust dependencies. This includes aws-lc-sys, which at the version used by librustls/rustls/aws-lc-rs (0.21.1) produces errors under the pedantic settings used by rustls-ffi for its examples. The warnings have been fixed upstream, but not for the version in use by rustls-ffi 0.14.x. To work around this issue we pass CFLAGS="" when running the make install for librustls 0.14.1.
Owner
|
Thanks a lot! Great! |
Owner
|
Merged via e343725 |
21 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
👋 @icing As promised here's a quick follow-up to #4
The
aws-lc-rsbuild issue ended up being specific to the 0.14.1 release. Our oldMakefilesetCFLAGSglobally with fairly aggressive settings for warnings. The intent was to use those settings when building theclient.candserver.cexamples, but it was inadvertently being used bycargowhen building native dependencies oflibrustls, likeaws-lc-sys.That was causing issues because the
aws-lc-sysversion in use doesn't build cleanly w/ that level of pedantic warnings and so was breaking the build. That's been tided up upstream by the AWS folks inaws-lc, but for 0.14.1 the easiest thing is to work around this by usingmake CFLAGS="" ... installin our CI.I also replaced the
cmakeusage with directcargo capiinvocation for simplicity/directness.Thanks again for getting the CI set up! Much appreciated 🙇