Unify fork management under forks/ directory#22
Merged
Conversation
Consolidate ccc-fork/, fork-scripts/, and reference/ into a single forks/ directory with forker as a self-managed fork entry. Pin files now include resolution fingerprints for deterministic reuse across re-records. - Move ccc-fork/pins/ → forks/.pin/ccc/, config → forks/config.json - Replace fork-scripts/ with forker (a fork entry managing itself) - Absorb reference/ repos as clone-only entries in forks/config.json - Move tsgo-filter.sh to repo root (no longer fork-scripts/ specific) - Update .pnpmfile.cjs to scan forks/config.json instead of *-fork/ - Update all workspace package.json refs from @ccc-fork/ to @forks/
Rewrite AGENTS.md fork management section, update README.md, and replace all ccc-fork/, fork-scripts/, reference/ paths throughout .planning/ docs to reflect the unified forks/ structure.
- dao.ts: "have" → "has" in error message - sdk.ts: compare against 0n instead of 0 for BigInt value - utils.ts: "or" → "of" in doc comment
Summary of ChangesHello @phroi, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly refactors the project's fork management system by centralizing all related tooling and configurations into a new Highlights
Changelog
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This is a substantial and well-executed structural refactor that unifies fork management under a new forks/ directory, consolidating what was previously scattered across ccc-fork/, fork-scripts/, and reference/. The new structure, with a centralized forks/config.json and a self-hosting forker tool, is a significant improvement in organization and clarity. The changes are applied consistently throughout the codebase, including all documentation and configuration files. The pull request also includes several beneficial small fixes, such as correcting a BigInt comparison bug, fixing typos, and optimizing the devcontainer setup. The overall quality of this refactoring is excellent. I have one minor suggestion for improving code style consistency.
Member
Author
|
LGTM Phroi %272 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The fork tooling was scattered across three separate directories (
ccc-fork/,fork-scripts/,reference/) with inconsistent conventions. This consolidates everything into a singleforks/directory where forker manages itself as a fork entry.Changes
ccc-fork/,fork-scripts/, andreference/intoforks/with a unifiedconfig.json. Forker becomes a self-managed fork entry. Pin files moved toforks/.pin/. All workspace refs updated from@ccc-fork/to@forks/.planning/docs0→0n), fix typo in utils.ts doc comment