Fix cell scan page size handling#55
Conversation
There was a problem hiding this comment.
Code Review
This pull request replaces the fail-closed sentinel scanning logic with a per-request page size configuration across the SDK, bot, and core packages, transitioning from collectCompleteScan to collectPagedScan. It also introduces transaction caching to reuse transaction header requests across lock scans. A review comment correctly points out an issue in packages/sdk/src/sdk.ts where findCellsOnChain is called with withData merged into the filter object instead of as a positional argument, which leads to misaligned arguments.
|
/gemini review |
There was a problem hiding this comment.
Code Review
This pull request replaces the sentinel-based fail-closed scanning limits with a unified, configurable cell query page size (cellPageSize / pageSize) across the SDK and core packages. This simplifies the scanning logic by tuning the paging size without capping the total results. Additionally, it introduces transaction and header caching in LogicManager and DaoManager to reuse requests across lock scans, improving performance. There are no review comments to address, and I have no further feedback to provide.
|
LGTM Phroi %198 |
Why
CCC cell scan
limitis a per-request page size, not a total-result cap. The stack was treating scan limits as completeness sentinels in several state-loading paths, which could turn valid paginated scans into false incomplete-state errors and forced bot runtime code to re-scan public pool deposits.Changes
cellPageSize, while lower-level managers usepageSizeand pass it positionally to CCC.