fix(supervisor): harden live loops and tester auto planning#58
Conversation
There was a problem hiding this comment.
Code Review
This pull request introduces a prebuild step for local runtimes (CCC, bot, tester, and supervisor) before running the supervisor loops, along with a --skip-build flag to bypass it. It also refactors the tester's transaction planning to handle cases with no actionable auto scenarios gracefully (returning undefined instead of throwing) and improves directory creation safety in the supervisor. Feedback on these changes suggests passing essential Windows environment variables during the prebuild step to prevent failures on Windows platforms, and removing a redundant check for selected === undefined in planTesterTransaction since the resolved scenario function already throws on failure.
|
/gemini review |
There was a problem hiding this comment.
Code Review
This pull request introduces several improvements to the supervisor and tester loops. Key changes include prebuilding the local runtime by default before running loops (with a new --skip-build option to bypass this), refactoring output directory and validation session root creation to recursively create parent directories first to prevent race conditions, and enhancing the tester's scenario resolution to return undefined and log a non-terminal skip when no actionable scenario is funded. Additionally, error reporting in the supervisor loop has been improved to capture and log child process spawn errors and signals when a run summary is missing. All review comments have been filtered out as they were redundant with the implemented changes, so we have no further feedback to provide.
|
LGTM Phroi %161 |
Why
Live supervisor loops should run against freshly built local runtime artifacts, reserve output/session directories without race-prone existence checks, and avoid leaking child process output when setup fails. Tester auto-planning should skip non-actionable balance states instead of selecting dust-sized raw orders.
Changes