Placeholders API Support (and preparation for the per-player patch)#69
Conversation
|
Also ignore the Italian lol |
|
The Placeholder API looks good, but I would like to keep all per-player power stuff separate. |
BlueZeeKing
left a comment
There was a problem hiding this comment.
Please remove the per-player power, as it's not done yet
|
Will be done tomorrow, right now I'm not at home and I'll be back late. |
|
Yeah this looks really good. The Placeholder API is awesome. I agree with @BlueZeeKing, probably best to remove the per player stuff until its done. Cheers! |
|
The only thing I'd like to keep from the extra methods is Also this should make easier in the future to add custom formulas via config if someone wants to work on it (like the original factions plugin) |
I 100% agree with this. When I reworked part of the config I had to change this in every single place when it could have just been one function. |
CamperSamu
left a comment
There was a problem hiding this comment.
Resolved with 868e9a1
|
I need to make the commit respect the config changes, working on it |
|
Now everything works with 66dcf3b and CI is passing, waiting on review and merge. |
BlueZeeKing
left a comment
There was a problem hiding this comment.
The Placeholder API is required while ideally, it would be optional. I could quickly fix this though and isn't that big of an issue
PAPI is JIJ-able, so it's fine like this, but if you want to change it to modCompile it's just a if statement in the mod init. |
This PR adds support for Patbox/TextPlaceholderAPI and adds 5 methods that will be used for a (still W.I.P.) per-player power and permission-based power patch.
If you don't want them I can just refactor the code and add back everything once the other patch is ready.
Placeholders added:
I'm also starting to work on a fork of this mod over at CampHQmc/factions where I will introduce more breaking and radical changes.