Add option to specify contents of resolver#5
Merged
adamgundry merged 3 commits intomainfrom Feb 22, 2023
Merged
Conversation
The problem with this is that the file doesn't include flags which still have their default values, yet the plan contains them (and doesn't have an indication that they are still the default).
This reverts commit 823912c.
adamgundry
changed the title
Contributor
Author
|
This seems to work in practice; the redundant flag values don't seem to matter. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a quickly hacked together attempt at #4. It adds a
--resolver-fileoption which expects the path to a YAML file in the format used by https://github.com/commercialhaskell/stackage-snapshots. It assumes that all such snapshots contain only Hackage packages.As far as package names/versions go this seems to work. However there is an issue with flags: the
plan.jsoncontains values for all flags in the build plan, whereas the snapshot YAML file contains only a few flags (presumably those with non-default values). Thus the generatedstack.yamlstill redundantly specifies many flag values. I'm not sure how much this matters; perhapsstackwill ignore the duplicate flag values?