Feature/fixes#170
Merged
siegfriedpammer merged 15 commits intomasterfrom Jul 4, 2019
Merged
Conversation
Member
Author
jogibear9988
force-pushed
the
feature/fixes
branch
from
c3dd254 to
2c3e3e6
Compare
Member
|
AppVeyor fails on Debug builds: https://ci.appveyor.com/project/icsharpcode/avalonedit/builds/25180893 - 129 out of 185 run, then it seems to be "gone". There has to be a change in here that makes Debug unit tests crash vs work a-ok on Release builds. |
…lename and name inside)
Member
Author
|
@christophwille now it's fixed. |
Member
|
@dgrunwald please have a quick look at it (&merge if ok) |
Member
Author
|
@dgrunwald is it okay to merge? |
Member
Author
|
@christophwille it's not enough if you review? |
Member
|
I can't do a techical review for AvalonEdit (way too little knowledge about architecture and code base) |
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Multiple fixes, should be merged only after netcore 3 port