Skip to content

Fix right to left reading order#308

Merged
dgrunwald merged 2 commits intoicsharpcode:masterfrom
doug24:right-to-left-flowdirection
Sep 4, 2022
Merged

Fix right to left reading order#308
dgrunwald merged 2 commits intoicsharpcode:masterfrom
doug24:right-to-left-flowdirection

Conversation

@doug24
Copy link
Copy Markdown
Contributor

@doug24 doug24 commented Oct 10, 2021

No description provided.

@doug24
Copy link
Copy Markdown
Contributor Author

doug24 commented May 20, 2022

I don't get it. Why has this never even been built? Is no one working on this project anymore?

@dgrunwald dgrunwald mentioned this pull request Sep 4, 2022
@dgrunwald
Copy link
Copy Markdown
Member

dgrunwald commented Sep 4, 2022

Yes, it's pretty much unmaintained.

I just tried your branch and there's a problem when toggling the FlowDirection:
image
Initially the contents of the text area are mirrored; only when when a re-render is forced (e.g. by selecting text) does the text render in the new mode. Should be an easy fix by handling FlowDirectionProperty in OnPropertyChanged.

@dgrunwald dgrunwald merged commit 08717da into icsharpcode:master Sep 4, 2022
@doug24 doug24 deleted the right-to-left-flowdirection branch September 4, 2022 20:27
@doug24
Copy link
Copy Markdown
Contributor Author

doug24 commented Sep 4, 2022

Thank-you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants