NotImplementedException when updating watch pad in decompiled code

[dgrunwald]

stepping through decompiled code with watch expressions causes the following exception:

SharpDevelop Version : 5.0.0.4140-Beta 2-f9ae991f
.NET Version         : 4.0.30319.18444
OS Version           : Microsoft Windows NT 6.1.7601 Service Pack 1
Current culture      : German (Austria) (de-AT)
Current UI language  : en
Running under WOW6432, processor architecture: x86-64
Working Set Memory   : 247244kb
GC Heap Memory       : 77349kb

Exception thrown:
System.NotImplementedException: The method or operation is not implemented.
   at ICSharpCode.ILSpyAddIn.ILSpyParser.ResolveSnippet(ParseInformation parseInfo, TextLocation location, String codeSnippet, ICompilation compilation, CancellationToken cancellationToken) in e:\Projects\SharpDevelop\SharpDevelop master\src\AddIns\DisplayBindings\ILSpyAddIn\ILSpyParser.cs:line 85
   at ICSharpCode.SharpDevelop.Parser.ParserService.ResolveSnippet(FileName fileName, TextLocation fileLocation, String codeSnippet, ITextSource fileContent, ICompilation compilation, CancellationToken cancellationToken) in e:\Projects\SharpDevelop\SharpDevelop master\src\Main\SharpDevelop\Parser\ParserService.cs:line 329
   at ICSharpCode.SharpDevelop.Services.WindowsDebugger.Evaluate(String code, Boolean allowMethodInvoke, Boolean allowSetValue) in e:\Projects\SharpDevelop\SharpDevelop master\src\AddIns\Debugger\Debugger.AddIn\Service\WindowsDebugger.cs:line 591
   at ICSharpCode.SharpDevelop.Gui.Pads.WatchPad.<>c__DisplayClassc.<MakeNode>b__8() in e:\Projects\SharpDevelop\SharpDevelop master\src\AddIns\Debugger\Debugger.AddIn\Pads\WatchPad.cs:line 120
   at Debugger.AddIn.TreeModel.ValueNode.GetValueAndUpdateUI() in e:\Projects\SharpDevelop\SharpDevelop master\src\AddIns\Debugger\Debugger.AddIn\TreeModel\ValueNode.cs:line 123
   at Debugger.AddIn.TreeModel.ValueNode..ctor(IImage image, String name, Func`1 getValue, Action`1 setValue) in e:\Projects\SharpDevelop\SharpDevelop master\src\AddIns\Debugger\Debugger.AddIn\TreeModel\ValueNode.cs:line 77
   at ICSharpCode.SharpDevelop.Gui.Pads.WatchPad.MakeNode(String name) in e:\Projects\SharpDevelop\SharpDevelop master\src\AddIns\Debugger\Debugger.AddIn\Pads\WatchPad.cs:line 116
   at ICSharpCode.SharpDevelop.Gui.Pads.WatchPad.<RefreshPad>b__f(String expr) in e:\Projects\SharpDevelop\SharpDevelop master\src\AddIns\Debugger\Debugger.AddIn\Pads\WatchPad.cs:line 145
   at Debugger.AddIn.TreeModel.Utils.ProcessItem[T](Process process, T item, Action`1 work, Int64 debuggeeStateWhenEnqueued) in e:\Projects\SharpDevelop\SharpDevelop master\src\AddIns\Debugger\Debugger.AddIn\TreeModel\Utils.cs:line 81

---- Recent log messages:
21:17:16.961 [1] DEBUG - Resolved (Line 34, Col 102) to 
21:17:17.056 [1] INFO - Debugger Command: StepOver
21:17:17.079 [1] INFO - Open file a:\Projects\JsonDemo\JsonDemo\Program.cs
21:17:17.092 [1] DEBUG - Resolved (Line 35, Col 5) to 
21:17:17.098 [1] INFO - Evaluating watch: reader == null
21:17:17.101 [1] DEBUG - Resolved (Line 35, Col 5) to [OperatorResolveResult System.Boolean]
21:17:17.106 [1] INFO - Evaluated node 'reader == null' in 6 ms
21:17:17.366 [1] DEBUG - Resolved (Line 35, Col 5) to 
21:17:18.086 [1] DEBUG - Resolved (Line 35, Col 5) to 
21:17:18.191 [1] INFO - Debugger Command: StepInto
21:17:18.218 [1] DEBUG - Service startup: ICSharpCode.SharpDevelop.Parser.IGlobalAssemblyCacheService
21:17:19.797 [1] INFO - Open file ilspy://A:/Projects/JsonDemo/JsonDemo/bin/Debug/Newtonsoft.Json.dll/Newtonsoft.Json.JsonTextReader.cs
21:17:20.417 [1] DEBUG - Folding update ignored; parse information is outdated version
21:17:21.003 [1] DEBUG - OpenedFileClosed: ilspy://A:/Projects/JsonDemo/JsonDemo/bin/Debug/Newtonsoft.Json.dll/Newtonsoft.Json.JsonTextReader.cs
21:17:21.005 [1] DEBUG - Resolved (Line 1, Col 1) to 
21:17:21.008 [1] DEBUG - ParseInformationUpdated ilspy://A:/Projects/JsonDemo/JsonDemo/bin/Debug/Newtonsoft.Json.dll/Newtonsoft.Json.JsonTextReader.cs (new)
21:17:21.009 [1] DEBUG - ParseInformationUpdated ilspy://A:/Projects/JsonDemo/JsonDemo/bin/Debug/Newtonsoft.Json.dll/Newtonsoft.Json.JsonTextReader.cs (updated)
21:17:21.010 [1] DEBUG - ParseInformationUpdated ilspy://A:/Projects/JsonDemo/JsonDemo/bin/Debug/Newtonsoft.Json.dll/Newtonsoft.Json.JsonTextReader.cs (updated)
21:17:21.010 [1] DEBUG - ActiveContentChanged to ICSharpCode.ILSpyAddIn.DecompiledViewContent
21:17:21.011 [1] DEBUG - ActiveWorkbenchWindowChanged to [AvalonWorkbenchWindow: [JsonTextReader]]
21:17:21.011 [1] DEBUG - NavigationService
    ActiveViewContent: [JsonTextReader]
              Subview: TabPageText
21:17:21.012 [1] DEBUG - ActiveViewContentChanged to ICSharpCode.ILSpyAddIn.DecompiledViewContent
21:17:21.020 [1] INFO - Evaluating watch: reader == null
21:17:22.761 [1] ERROR - 
--> Exception:
System.NotImplementedException: The method or operation is not implemented.
   at ICSharpCode.ILSpyAddIn.ILSpyParser.ResolveSnippet(ParseInformation parseInfo, TextLocation location, String codeSnippet, ICompilation compilation, CancellationToken cancellationToken) in e:\Projects\SharpDevelop\SharpDevelop master\src\AddIns\DisplayBindings\ILSpyAddIn\ILSpyParser.cs:line 85
   at ICSharpCode.SharpDevelop.Parser.ParserService.ResolveSnippet(FileName fileName, TextLocation fileLocation, String codeSnippet, ITextSource fileContent, ICompilation compilation, CancellationToken cancellationToken) in e:\Projects\SharpDevelop\SharpDevelop master\src\Main\SharpDevelop\Parser\ParserService.cs:line 329
   at ICSharpCode.SharpDevelop.Services.WindowsDebugger.Evaluate(String code, Boolean allowMethodInvoke, Boolean allowSetValue) in e:\Projects\SharpDevelop\SharpDevelop master\src\AddIns\Debugger\Debugger.AddIn\Service\WindowsDebugger.cs:line 591
   at ICSharpCode.SharpDevelop.Gui.Pads.WatchPad.<>c__DisplayClassc.<MakeNode>b__8() in e:\Projects\SharpDevelop\SharpDevelop master\src\AddIns\Debugger\Debugger.AddIn\Pads\WatchPad.cs:line 120
   at Debugger.AddIn.TreeModel.ValueNode.GetValueAndUpdateUI() in e:\Projects\SharpDevelop\SharpDevelop master\src\AddIns\Debugger\Debugger.AddIn\TreeModel\ValueNode.cs:line 123
   at Debugger.AddIn.TreeModel.ValueNode..ctor(IImage image, String name, Func`1 getValue, Action`1 setValue) in e:\Projects\SharpDevelop\SharpDevelop master\src\AddIns\Debugger\Debugger.AddIn\TreeModel\ValueNode.cs:line 77
   at ICSharpCode.SharpDevelop.Gui.Pads.WatchPad.MakeNode(String name) in e:\Projects\SharpDevelop\SharpDevelop master\src\AddIns\Debugger\Debugger.AddIn\Pads\WatchPad.cs:line 116
   at ICSharpCode.SharpDevelop.Gui.Pads.WatchPad.<RefreshPad>b__f(String expr) in e:\Projects\SharpDevelop\SharpDevelop master\src\AddIns\Debugger\Debugger.AddIn\Pads\WatchPad.cs:line 145
   at Debugger.AddIn.TreeModel.Utils.ProcessItem[T](Process process, T item, Action`1 work, Int64 debuggeeStateWhenEnqueued) in e:\Projects\SharpDevelop\SharpDevelop master\src\AddIns\Debugger\Debugger.AddIn\TreeModel\Utils.cs:line 81
21:17:22.781 [1] WARN - Stack trace of last exception log:
   at System.Environment.GetStackTrace(Exception e, Boolean needFileInfo)
   at System.Environment.get_StackTrace()
   at ICSharpCode.SharpDevelop.Logging.SDMessageService.ShowException(Exception ex, String message) in e:\Projects\SharpDevelop\SharpDevelop master\src\Main\SharpDevelop\Logging\SDMessageService.cs:line 29
   at ICSharpCode.Core.MessageService.ShowException(Exception ex, String message) in e:\Projects\SharpDevelop\SharpDevelop master\src\Main\Core\Project\Src\Services\MessageService\MessageService.cs:line 59
   at Debugger.AddIn.TreeModel.Utils.ProcessItem[T](Process process, T item, Action`1 work, Int64 debuggeeStateWhenEnqueued) in e:\Projects\SharpDevelop\SharpDevelop master\src\AddIns\Debugger\Debugger.AddIn\TreeModel\Utils.cs:line 87
   at Debugger.AddIn.TreeModel.Utils.<>c__DisplayClass6`1.<EnqueueForEach>b__3() in e:\Projects\SharpDevelop\SharpDevelop master\src\AddIns\Debugger\Debugger.AddIn\TreeModel\Utils.cs:line 69
   at System.Windows.Threading.ExceptionWrapper.InternalRealCall(Delegate callback, Object args, Int32 numArgs)
   at MS.Internal.Threading.ExceptionFilterHelper.TryCatchWhen(Object source, Delegate method, Object args, Int32 numArgs, Delegate catchHandler)
   at System.Windows.Threading.DispatcherOperation.InvokeImpl()
   at System.Windows.Threading.DispatcherOperation.InvokeInSecurityContext(Object state)
   at System.Threading.ExecutionContext.RunInternal(ExecutionContext executionContext, ContextCallback callback, Object state, Boolean preserveSyncCtx)
   at System.Threading.ExecutionContext.Run(ExecutionContext executionContext, ContextCallback callback, Object state, Boolean preserveSyncCtx)
   at System.Threading.ExecutionContext.Run(ExecutionContext executionContext, ContextCallback callback, Object state)
   at System.Windows.Threading.DispatcherOperation.Invoke()
   at System.Windows.Threading.Dispatcher.ProcessQueue()
   at System.Windows.Threading.Dispatcher.WndProcHook(IntPtr hwnd, Int32 msg, IntPtr wParam, IntPtr lParam, Boolean& handled)
   at MS.Win32.HwndWrapper.WndProc(IntPtr hwnd, Int32 msg, IntPtr wParam, IntPtr lParam, Boolean& handled)
   at MS.Win32.HwndSubclass.DispatcherCallbackOperation(Object o)
   at System.Windows.Threading.ExceptionWrapper.InternalRealCall(Delegate callback, Object args, Int32 numArgs)
   at MS.Internal.Threading.ExceptionFilterHelper.TryCatchWhen(Object source, Delegate method, Object args, Int32 numArgs, Delegate catchHandler)
   at System.Windows.Threading.Dispatcher.LegacyInvokeImpl(DispatcherPriority priority, TimeSpan timeout, Delegate method, Object args, Int32 numArgs)
   at MS.Win32.HwndSubclass.SubclassWndProc(IntPtr hwnd, Int32 msg, IntPtr wParam, IntPtr lParam)
   at MS.Win32.UnsafeNativeMethods.DispatchMessage(MSG& msg)
   at System.Windows.Threading.Dispatcher.PushFrameImpl(DispatcherFrame frame)
   at System.Windows.Threading.Dispatcher.PushFrame(DispatcherFrame frame)
   at System.Windows.Threading.Dispatcher.Run()
   at System.Windows.Application.RunDispatcher(Object ignore)
   at System.Windows.Application.RunInternal(Window window)
   at System.Windows.Application.Run(Window window)
   at ICSharpCode.SharpDevelop.Workbench.WorkbenchStartup.Run(IList`1 fileList) in e:\Projects\SharpDevelop\SharpDevelop master\src\Main\SharpDevelop\Workbench\WorkbenchStartup.cs:line 156
   at ICSharpCode.SharpDevelop.Sda.CallHelper.RunWorkbenchInternal(Object settings) in e:\Projects\SharpDevelop\SharpDevelop master\src\Main\SharpDevelop\Sda\CallHelper.cs:line 167
   at ICSharpCode.SharpDevelop.Sda.CallHelper.RunWorkbench(WorkbenchSettings settings) in e:\Projects\SharpDevelop\SharpDevelop master\src\Main\SharpDevelop\Sda\CallHelper.cs:line 143
   at ICSharpCode.SharpDevelop.Sda.SharpDevelopHost.RunWorkbench(WorkbenchSettings settings) in e:\Projects\SharpDevelop\SharpDevelop master\src\Main\SharpDevelop\Sda\SharpDevelopHost.cs:line 129
   at ICSharpCode.SharpDevelop.Startup.SharpDevelopMain.RunApplication() in e:\Projects\SharpDevelop\SharpDevelop master\src\Main\SharpDevelop\Startup\SharpDevelopMain.cs:line 226
   at ICSharpCode.SharpDevelop.Startup.SharpDevelopMain.Run() in e:\Projects\SharpDevelop\SharpDevelop master\src\Main\SharpDevelop\Startup\SharpDevelopMain.cs:line 124
   at ICSharpCode.SharpDevelop.Startup.SharpDevelopMain.Main(String[] args) in e:\Projects\SharpDevelop\SharpDevelop master\src\Main\SharpDevelop\Startup\SharpDevelopMain.cs:line 71

---- Post-error application state information:
Installed 3rd party AddIns: [PInvoke Add-in 0.0.0.0]
ProjectService.CurrentSolution: [Solution A:\Projects\JsonDemo\JsonDemo.sln with 3 projects]
ProjectService.CurrentProject: [CSharpProject: JsonDemo]
Workbench.ActiveContent: ICSharpCode.ILSpyAddIn.DecompiledViewContent

[dgrunwald]

Code completion in watches is always for C#, but when evaluating the watch expression, we're using the language of the active source code location?
That's inconsistent; we should probably always evaluate watch expressions as C#, and use ResolveContext() to grab the initial resolver state.

[dgrunwald]

I have removed the NotImplementedException; the ILSpyParser now returns ErrorResolveResult.UnknownError when asked to resolve snippets. This avoids the exception, but the watch expression still cannot be evaluated.