This repository was archived by the owner on Oct 16, 2020. It is now read-only.
CodeCoverage again#335
Merged
mrward merged 2 commits intoicsharpcode:masterfrom Feb 3, 2014
ddur:master
Merged
Conversation
added 2 commits
February 2, 2014 23:15
By ccrewrite inserted alien SequencePoints GetText() receives lots of invalid calls
Author
|
Btw, how often is StringResource.resx updated from database to GitHub and how/where can I see that database or UI access? http://www.youtube.com/watch?v=PFrufPxjwX0&feature=player_detailpage#t=163 |
Member
|
Usually it is updated when a developer adds new string resources and also before a new release. There is a web site for reading/updating the string resources which you will need an account to use. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removed CodeCoverageStringTextSource debug assertions/failures.
Why?
Running SD5 in debug mode large number of assertions is revealed.
Why?
When using CodeContract ContractClass/ContractClassFor attributes,
ccrewrite inserts in "ContractClass" attributed class/interface SequencePoints from "ContractClassFor" attributed class. If "ContractClassFor" class is in another file, CodeCoverageStringTextSource.GetText(..) receives invalid line/column/endline/endcolumn arguments that fails or do not exists in file containing "ContractClass" attributed class/interface.
Why?
Afaik, cannot avoid invalid requests, because to filter them out, first need GetText() for all SequencePoints.
CodeCoverageMethodElement.cs changes & refactoring
Why?
While trying to fix 1), in some rare cases SequencePoints are omitted.
I certify that I own, and have sufficient rights to contribute, all source code and related material intended to be compiled or integrated with the source code for the #develop open source product (the "Contribution"). My Contribution is licensed under the MIT License.