Skip to content
This repository was archived by the owner on Oct 16, 2020. It is now read-only.

Add "Browse Project" and "Browse Solution" buttons#392

Closed
linquize wants to merge 1 commit intoicsharpcode:masterfrom
linquize:add-reference
Closed

Add "Browse Project" and "Browse Solution" buttons#392
linquize wants to merge 1 commit intoicsharpcode:masterfrom
linquize:add-reference

Conversation

@linquize
Copy link
Copy Markdown
Contributor

@linquize linquize commented Mar 7, 2014

This facilitates choosing more DLL from project's directory or solution's directory.
The original button renamed as "Browse Last" and it remains opening last directory chosen.

I certify that I own, and have sufficient rights to contribute, all source code and related material intended to be compiled or integrated with the source code for the #develop open source product (the "Contribution"). My Contribution is licensed under the MIT License.

This facilitates choosing more DLL from project's directory or solution's directory.
The original button renamed as "Browse Last" and it remains opening last directory chosen.
@linquize
Copy link
Copy Markdown
Contributor Author

Any comments?

@dgrunwald
Copy link
Copy Markdown
Member

I think this might be confusing UI, "Browse project" might be misinterpreted as "Browse for project", not "Browse with the project directory as initial directory".

I think it would be better to show the project/solution directories within the browse dialog (in the list of favorites or libraries). I think the Windows OpenFileDialog allows customizing that list, but I'm not sure if the WinForms/WPF APIs expose that functionality. We might have to directly use the Win32 API (or use some existing wrapper like VistaBridge)

@linquize
Copy link
Copy Markdown
Contributor Author

linquize commented Apr 2, 2014

No, I do not quite like the "favorite list" since VS2012. It is a trap.
Developers may easily select DLLs outside the project/solution, which causes broken build on other machines.

@dgrunwald
Copy link
Copy Markdown
Member

I think this is highly confusing UI; users expect different buttons to open different dialogs, not just control the initial directory.

@dgrunwald dgrunwald closed this Apr 5, 2014
@linquize
Copy link
Copy Markdown
Contributor Author

linquize commented Apr 6, 2014

What if it looks like this?
sharpdevelopbrowsereference

dgrunwald added a commit that referenced this pull request Jun 27, 2014
9d875d3 Bump NRefactory version number to 5.4.
ebe00cc ConsistencyCheck: Ensure mscorlib is added to the compilation (MSBuild doesn't return it for .NET 2.0 projects like IKVM)
d68853d Fix missing FreezeList() call to DefaultUnresolvedTypeParameter.Freeze().
a71bf19 Merge several bugfixes from SharpDevelop repository to NRefactory.
6856bd1 Remove System.Runtime hack -- type forwarding should handle this case.
17aefe2 Handle blob decoding errors in the type system instead of placing catch-all handlers in random spots.
877394a Mark DefaultAssemblyReference.Corlib as obsolete
f70e546 Updated mcs.
7a2614d Fixed null check
48bdfd7 Merge pull request #405 from DavidKarlas/paramBug
e6ce1e6 Fixing parameter code completion after using '>' e.g. if(a>b)Method(
6da0a7b Ignored failing unit test.
4d0b4a4 Fixed 'Bug 20110 - [Forms] Autocomplete doesn't work for the Placeholder property'.
e5958a8 Fixed another completion bug case.
37368af Fixed completion bug.
67a1d11 Disabled uncategorized/notworking code issues.
cf4fc70 Disabled notworking code issue. That's fixed in .NET 4.5 anyways and this code issue was very, very slow.
39bb34a Remap failing system.runtime references to mscorlib. Use case: Reference portable.NET assemblies from non portable .NET code.
44e1ff1 Fixed Bug 20125 - Fails to show abstract method when writing "override"
c47e3d1 Fixed little bug in resolver. It incorrectly resolved internal types sometimes.
6c4c6d3 Fixed wrong end location of RedundantAttributeParenthesesIssue. Due to a drawing error in monodevelop that wasn't visible before.
2b69be0 Fixed bug in inconsistent naming tests.
3c9256f Merge pull request #404 from mono-soc-2013/MateY-IndentEngine
4733874 Fixed issue 389.
c0aebb7 Fixed issue in ResolveAtLocation. On indexer 'this' the indexer should be resolved.
1c48cd2 Merge pull request #400 from DavidKarlas/parseExpression
242c141 Fixed parser bug when using ParseExpression
9d1cc09 Fixed parser bug.
13b0928 Catches exception for the IsBrowsable extension method. Fixed monodevelop bug https://bugzilla.xamarin.com/show_bug.cgi?id=18706.
3f78bdb Merge pull request #397 from khellang/patch-1
f6e7c08 Update README
0b743ac Merge pull request #396 from Therzok/master
36d6246 Optimize some Linq.
75640bf Merge pull request #395 from Therzok/master
5789870 [CodeIssues] Add simplified versions Math functions.
28d04ae Fixed potential blob reader exception.
22d8bc2 Fixed failing unit tests.
e2dced7 Merge branch 'master' of github.com:icsharpcode/NRefactory
705590d Merge pull request #392 from DavidKarlas/paramInfoAnywhere
800296d Merge pull request #393 from DavidKarlas/failRevert
63a63f2 Correcting bad revert. Sometimes it was returing 0 instead of -1.
27590b5 Improved resolving of target method for ParameterInfo so it can be triggered in middle of parameter and not only after '(',',','[' or '<'.
7aef513 Merge pull request #391 from DavidKarlas/revertPull390
a8141ef Reverting Pull #390
2132edc Merge pull request #390 from DavidKarlas/firstParameter
b6ccdb9 Always displaying first parameter discription in ParameterInfo tooltip
dgrunwald pushed a commit to dgrunwald/SharpDevelop that referenced this pull request Jun 27, 2014
Improved resolving of target method for ParameterInfo
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants