Skip to content
This repository was archived by the owner on Oct 16, 2020. It is now read-only.

.gitignore /packages/#480

Merged
Rpinski merged 3 commits intoicsharpcode:masterfrom
ddur:master
May 30, 2014
Merged

.gitignore /packages/#480
Rpinski merged 3 commits intoicsharpcode:masterfrom
ddur:master

Conversation

@ddur
Copy link
Copy Markdown

@ddur ddur commented May 19, 2014

Ignore restored package: "Machine.Specifications.0.4.9.0"

Dragan added 2 commits May 19, 2014 01:34
@Rpinski
Copy link
Copy Markdown
Member

Rpinski commented May 27, 2014

Wouldn't it be better to include *.sln.sdsettings files with correctly defined formatter settings? That's what these files are intended for.

@dgrunwald
Copy link
Copy Markdown
Member

Why do the *.sln.sdsettings files get written to disk if the user didn't customize any formatter settings?

siegfriedpammer added a commit that referenced this pull request May 27, 2014
…s should not be marked dirty (see discussion #480)
@Rpinski
Copy link
Copy Markdown
Member

Rpinski commented May 27, 2014

Should be better now, now they are only created when user really changes at least one formatting option (and saves that change).

But there's still the quetion: Should we actively use the .sln.sdsettings files in SD solution itself?

@ddur
Copy link
Copy Markdown
Author

ddur commented May 28, 2014

I had to manually exclude that .sdsettings file appearing from nowhere, I guess other people to.
Now, given that sln.sdsettings file is not anymore created without real change, if you like, I will rollback that second commit?
If is not ignored, then is still under control for any possible future change.

@Rpinski
Copy link
Copy Markdown
Member

Rpinski commented May 29, 2014

Yes, would be good. Then we can still decide, if it's sensible to define solution-wide formatter settings for SD projects and submit them in repository.

@ddur
Copy link
Copy Markdown
Author

ddur commented May 29, 2014

Done

Rpinski added a commit that referenced this pull request May 30, 2014
@Rpinski Rpinski merged commit 94e2619 into icsharpcode:master May 30, 2014
@Rpinski
Copy link
Copy Markdown
Member

Rpinski commented May 30, 2014

Thx.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants