This repository was archived by the owner on Oct 16, 2020. It is now read-only.
Fix for bug introduced with new snapline behaviour#493
Merged
siegfriedpammer merged 1 commit intoicsharpcode:masterfrom Jun 11, 2014
Merged
Fix for bug introduced with new snapline behaviour#493siegfriedpammer merged 1 commit intoicsharpcode:masterfrom
siegfriedpammer merged 1 commit intoicsharpcode:masterfrom
Conversation
Contributor
Author
|
For clarification, the bug that happens with the second setup is that only the center snaplines are shown, snaplines for other controls are not shown at all. |
siegfriedpammer
added a commit
that referenced
this pull request
Jun 11, 2014
Fix for bug introduced with new snapline behaviour
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As long as the document follows the following pattern (as a "new window" in SD does) the current code in SD-master works as expected.
But if we introduce another setup, for example the following, it does not work anymore (but did work before the snapline changes was merged).
This fix make it work as expected. I have discussed this fix with jogibear9988 that introduced the new snapline features and he has approved this fix.