BenchmarkDotNet

[Numpsy]

Would there be any interest in adding a BenchmarkDotNet benchmark project to the official branch?

e.g. Numpsy@a22ed77

Can be useful for testing performance of changes and such, e.g.

Using the master branch:

CRC32 benchmark: 

|             Method |     Toolchain |    Mean |    Error |   StdDev | Ratio |
|------------------- |-------------- |--------:|---------:|---------:|------:|
|   Crc32LargeUpdate | .NET Core 2.1 | 1.017 s | 0.0023 s | 0.0020 s |  1.00 |
|   Crc32LargeUpdate |        net471 | 1.021 s | 0.0066 s | 0.0062 s |  1.00 |

ZipOutputStream benchmark:

|               Method |     Toolchain |     Mean |    Error |   StdDev | Ratio |
|--------------------- |-------------- |---------:|---------:|---------:|------:|
| WriteZipOutputStream | .NET Core 2.1 | 704.3 ms | 2.094 ms | 1.635 ms |  1.00 |
| WriteZipOutputStream |        net471 | 706.8 ms | 4.888 ms | 4.333 ms |  1.00 |

vs. using PR #319

CRC32 benchmark: 

|             Method |     Toolchain |     Mean |     Error |    StdDev | Ratio |
|------------------- |-------------- |---------:|----------:|----------:|------:|
|   Crc32LargeUpdate | .NET Core 2.1 | 201.2 ms | 0.6512 ms | 0.5438 ms |  0.99 |
|   Crc32LargeUpdate |        net471 | 203.8 ms | 0.5946 ms | 0.5271 ms |  1.00 |

ZipOutputStream benchmark:

|               Method |     Toolchain |     Mean |     Error |    StdDev | Ratio |
|--------------------- |-------------- |---------:|----------:|----------:|------:|
| WriteZipOutputStream | .NET Core 2.1 | 503.5 ms | 0.6950 ms | 0.6501 ms |  0.98 |
| WriteZipOutputStream |        net471 | 513.3 ms | 2.3856 ms | 1.9921 ms |  1.00 |

[piksel]

Sure! I have mostly written performance tests using Stopwatch before, but it's not ideal.

[decipherer]

Great! I created a separate test project specifically for testing the CRC32 changes, but it's a lot better to have this integrated in the official branch.