Skip to content

Fix testcase#11

Merged
akbargumbira merged 1 commit intoid-python:developfrom
iromli:fix-testcase
Jun 28, 2014
Merged

Fix testcase#11
akbargumbira merged 1 commit intoid-python:developfrom
iromli:fix-testcase

Conversation

@iromli
Copy link
Copy Markdown
Member

@iromli iromli commented Jun 24, 2014

This changeset contains minor fixes:

  • users/utilities/test/test_db_handler.py: previous testcase failed because we're sending 10 values into 9-columns table
  • by adding MAIL_SUPPRESS_SEND option, runtests.sh will not send the actual email; quite useful for people who don't have mail server installed on their machines

@iromli
Copy link
Copy Markdown
Member Author

iromli commented Jun 24, 2014

Oh, TESTING (https://github.com/id-python/members/blob/develop/users/config.py.test#L29) does the same thing with MAIL_SUPPRESS_SEND. Likely i was using a production configuration then.

I will leave MAIL_SUPPRESS_SEND there just for clarity.

@akbargumbira
Copy link
Copy Markdown
Member

Hi @iromli, thanks for the PR. I will merge this

akbargumbira added a commit that referenced this pull request Jun 28, 2014
@akbargumbira akbargumbira merged commit bf84216 into id-python:develop Jun 28, 2014
@iromli
Copy link
Copy Markdown
Member Author

iromli commented Jun 28, 2014

@akbargumbira thanks

@iromli iromli deleted the fix-testcase branch June 28, 2014 04:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants