Conversation
Adding CLAUDE.md with task information for AI processing. This file will be removed when the task is complete. Issue: #276
Pass metadata type information to formatSubordinateCellValue() for the
first column in subordinate tables. This ensures proper formatting based
on the column's data type (e.g., DATE displays as dd.mm.yyyy, DATETIME
as dd.mm.yyyy hh:mm:ss, BOOLEAN as Да/Нет, etc.).
Previously, the first column was always rendered as plain text because
null was passed as the type parameter. Now it receives { type: metadata.type }
which allows the existing formatting logic to work correctly.
Fixes #276
Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
This reverts commit af3eec6.
Collaborator
Author
🤖 Solution Draft LogThis log file contains the complete execution trace of the AI solution draft process. 💰 Cost estimation:
Now working session is ended, feel free to review and add any feedback on the solution draft. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎯 Summary
This pull request fixes the formatting of the first column in subordinate tables (табличные реквизиты) by applying proper type-based formatting according to metadata.
📋 Issue Reference
Fixes #276
🔧 Changes Made
Problem
The first column in subordinate tables (
.subordinate-cell-clickable) was always displayed as plain text, regardless of its data type. For example:Root Cause
In
renderSubordinateTable()at line 3217, the code was passingnullas the type parameter toformatSubordinateCellValue():This meant the formatting logic couldn't determine the proper format for the value.
Solution
Modified the code to pass metadata type information:
Now the first column is formatted according to its type ID from metadata, using the same logic that already works for other columns in subordinate tables.
🧪 Testing
The fix leverages existing formatting logic that already works correctly:
formatSubordinateCellValue()method has proven formatting logic for DATE, DATETIME, BOOLEAN typesgetFormatById()according to TABLE_COMPONENT_README.md📝 Technical Details
Type Mapping (from TABLE_COMPONENT_README.md):
Files Modified:
assets/js/integram-table.js- Added type parameter to first column formatting in subordinate tables🤖 This PR was created by the AI issue solver