fix: highlight only empty required fields in table edit mode (issue #785)#786
Merged
fix: highlight only empty required fields in table edit mode (issue #785)#786
Conversation
Adding .gitkeep for PR creation (default mode). This file will be removed when the task is complete. Issue: #785
) Previously, highlightRequiredCells() highlighted all required fields (:!NULL: in attrs) when entering edit mode. This fix modifies it to only highlight required fields that are currently empty, so already- filled fields are not highlighted unnecessarily. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This reverts commit a653b03.
Collaborator
Author
🤖 Solution Draft LogThis log file contains the complete execution trace of the AI solution draft process. 💰 Cost estimation:
Now working session is ended, feel free to review and add any feedback on the solution draft. |
Collaborator
Author
✅ Ready to mergeThis pull request is now ready to be merged:
Monitored by hive-mind with --auto-restart-until-mergeable flag |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤖 AI-Powered Solution
Fixes #785
📋 Problem
PR #780 introduced
highlightRequiredCells()to visually highlight required fields (columns with:!NULL:in theirattrs) when a user enters edit mode for a row. However, it highlighted all required fields, including those that already have a value filled in.✅ Fix
Modified
highlightRequiredCells()injs/integram-table.jsto only add therequired-field-editingCSS class to cells that are currently empty. This is done by calling the existingextractCellValue(td)method and skipping the highlight if the value is non-empty.📁 Files Changed
js/integram-table.js— added empty-value check before applyingrequired-field-editingclassThis PR was created automatically by the AI issue solver