fix bug where terms/aliases are not expanded for en.json#280
Merged
Conversation
Contributor
|
looking at changes like this... I think it would be nice to have some tests in this repo |
Collaborator
Author
|
if we merged this repo into id-tagging-schema, we wouldn't need tests, because you could just run so i hope that this is is one of the last few PRs where we have to deal with this weird repo setup... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes a bug caused by #227 (which hasn't been released yet).
en.json is special, it uses different code compared to all the translation files. The logic in #227 didn't affect
en.json, which is a bug.The git diff looks big, but the changes in this PR are actually quite small: 60 lines were just copied into a helper function, so that it can be re-used in a different place.
testing log
Testing anything in this repo is a real pain. In iD tagging schema, I ran:
and then check the diff between the two commits. f2b680 is the result when i ran these steps. The only affected files are
en.jsonanden.min.json