Skip to content

allow icons for radio field#291

Merged
tyrasd merged 1 commit intoideditor:mainfrom
matkoniecz:allow_icons_in_radio
Apr 28, 2026
Merged

allow icons for radio field#291
tyrasd merged 1 commit intoideditor:mainfrom
matkoniecz:allow_icons_in_radio

Conversation

@matkoniecz
Copy link
Copy Markdown
Contributor

fixes #290

Copy link
Copy Markdown
Collaborator

@k-yle k-yle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i can confirm that there's no JSON schema changes required, so this docs change is sufficient

LGTM since it's documenting an existing practice (although iD doesn't use the icons for radio)

@matkoniecz
Copy link
Copy Markdown
Contributor Author

"documenting an existing practice" is overstating it a bit, given it is single PR where I kind of forgot about icons...

but still - icons for radio selectors seem viable, also in iD

Copy link
Copy Markdown
Collaborator

@tyrasd tyrasd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yep, icons make sense and should also be allowed also for the radio type (as it is essentially just a permanently expanded combo field).

@tyrasd tyrasd added the documentation Improvements or additions to documentation label Apr 28, 2026
@tyrasd tyrasd merged commit 697209e into ideditor:main Apr 28, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Allow icons for radio-type presets

3 participants