allow icons for radio field#291
Merged
tyrasd merged 1 commit intoideditor:mainfrom Apr 28, 2026
Merged
Conversation
k-yle
approved these changes
Apr 22, 2026
Collaborator
k-yle
left a comment
There was a problem hiding this comment.
i can confirm that there's no JSON schema changes required, so this docs change is sufficient
LGTM since it's documenting an existing practice (although iD doesn't use the icons for radio)
Contributor
Author
|
"documenting an existing practice" is overstating it a bit, given it is single PR where I kind of forgot about icons... but still - icons for radio selectors seem viable, also in iD |
tyrasd
approved these changes
Apr 28, 2026
Collaborator
tyrasd
left a comment
There was a problem hiding this comment.
yep, icons make sense and should also be allowed also for the radio type (as it is essentially just a permanently expanded combo field).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #290