Add Pinhead as icon source.#300
Conversation
| | [Font Awesome Solid](https://fontawesome.com/search?o=r&ic=free&s=solid) | `fas-` | Solid style icons from Font Awesome (free tier) | [Preview](https://icones.js.org/collection/fa7-solid) | | ||
| | [Font Awesome Regular](https://fontawesome.com/search?o=r&ic=free&s=regular) | `far-` | Regular style icons from Font Awesome (free tier) | [Preview](https://icones.js.org/collection/fa7-regular) | | ||
| | [Font Awesome Brands](https://fontawesome.com/search?o=r&ic=free&ip=brands) | `fab-` | Brand icons from Font Awesome (free tier) | [Preview](https://icones.js.org/collection/fa7-brands) | | ||
| | [Pinhead](https://pinhead.ink/) | `pinhead-` | Public domain icons for map pins | [Preview](https://pinhead.ink/) | |
There was a problem hiding this comment.
matching preview link blocked by iconify/icon-sets#304
There was a problem hiding this comment.
added (with comment "Really good set"), new release of icones not done yet I guess as it is not on the live site
TODO: check in few hours/days: https://icones.js.org/collection/pinhead https://icones.js.org/
|
If I'm reading this right then it looks like you're using the full icon path in the source repo as the ID? I wouldn't recommend using Pinhead this way since these paths are not considered part of the identifier and aren't stable. Instead I would use the NPM release or the web endpoint like: https://pinhead.ink/v23/baby.svg I guess if you really don't want to deal with versioning then I could add an endpoint like: https://pinhead.ink/latest/baby.svg |
|
@quincylvania the id for the icon would be |
|
@quincylvania I did it exactly to avoid version-specific link as it would keep changing whenever icon set would release a new version
Though I am surprised that this link is unstable |
|
@quincylvania also big thanks for this icon set! I only started exploring it and I found some useful icons already |
|
Okay I opened an issue (waysidemapping/pinhead#223) and will try to implement it today or tomorrow.
This works if an icon is in the root directory, but for
This is intentional, mainly to enforce abstraction between the source files and the distributed files. E.g. icons can easily be recategorized in subdirectories to aid with navigation. The whole build pipeline could be refactored in the future if needed. This is more complex than most icon repos which are just a bucket of files, but I think it's helpful given Pinhead already has nearly 2,000 icons and growing.
I'm glad to hear it! Feel free to open issues if anything is missing or inconsistent. |
|
But https://pinhead.ink/latest/baby.svg will be resistant to categorisation changes etc, right? Obviously icon content can change if it will be updated and icon name can potentially change. |
I will likely do this, thanks for invitation. (Roentgen project added some icons that become used in iD presets as soon as released and I have somewhere list of further missing icons... I will see what is missing also from the current Pinhead) |
|
Converting to draft as the current icon sourcing is not recommended and new one requires some work to be done upstream |
|
Okay I added the
Right, these endpoints should never 404. Even in the rare case an icon is renamed then the old name will continue to point to the same icon (but it will not receive any design updates). |
|
@quincylvania I am quite excited about possibility to use (soon) Pinhead icons in all these editors :) Thanks for making that collection! |
|
@matkoniecz Thanks for integrating! Excited to see Pinhead in more places. |
fixes #277