Skip to content

Add Pinhead as icon source.#300

Merged
tyrasd merged 5 commits into
ideditor:mainfrom
matkoniecz:pinhead
May 19, 2026
Merged

Add Pinhead as icon source.#300
tyrasd merged 5 commits into
ideditor:mainfrom
matkoniecz:pinhead

Conversation

@matkoniecz
Copy link
Copy Markdown
Contributor

fixes #277

@tyrasd tyrasd added this to the v7 milestone May 12, 2026
Comment thread ICONS.md
| [Font Awesome Solid](https://fontawesome.com/search?o=r&ic=free&s=solid) | `fas-` | Solid style icons from Font Awesome (free tier) | [Preview](https://icones.js.org/collection/fa7-solid) |
| [Font Awesome Regular](https://fontawesome.com/search?o=r&ic=free&s=regular) | `far-` | Regular style icons from Font Awesome (free tier) | [Preview](https://icones.js.org/collection/fa7-regular) |
| [Font Awesome Brands](https://fontawesome.com/search?o=r&ic=free&ip=brands) | `fab-` | Brand icons from Font Awesome (free tier) | [Preview](https://icones.js.org/collection/fa7-brands) |
| [Pinhead](https://pinhead.ink/) | `pinhead-` | Public domain icons for map pins | [Preview](https://pinhead.ink/) |
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

matching preview link blocked by iconify/icon-sets#304

Copy link
Copy Markdown
Contributor Author

@matkoniecz matkoniecz May 19, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added (with comment "Really good set"), new release of icones not done yet I guess as it is not on the live site

iconify/icon-sets@540c25d


TODO: check in few hours/days: https://icones.js.org/collection/pinhead https://icones.js.org/

@quincylvania
Copy link
Copy Markdown
Contributor

If I'm reading this right then it looks like you're using the full icon path in the source repo as the ID? I wouldn't recommend using Pinhead this way since these paths are not considered part of the identifier and aren't stable. Instead I would use the NPM release or the web endpoint like: https://pinhead.ink/v23/baby.svg

I guess if you really don't want to deal with versioning then I could add an endpoint like: https://pinhead.ink/latest/baby.svg

@tordans
Copy link
Copy Markdown
Collaborator

tordans commented May 14, 2026

@quincylvania the id for the icon would be pinhead-slide. Is the URL in this PR not stable? In this case a "latest" would be helpful.

@matkoniecz
Copy link
Copy Markdown
Contributor Author

@quincylvania I did it exactly to avoid version-specific link as it would keep changing whenever icon set would release a new version

latest would be appreciated

Though I am surprised that this link is unstable

@matkoniecz
Copy link
Copy Markdown
Contributor Author

@quincylvania also big thanks for this icon set! I only started exploring it and I found some useful icons already

@quincylvania
Copy link
Copy Markdown
Contributor

Okay I opened an issue (waysidemapping/pinhead#223) and will try to implement it today or tomorrow.

the id for the icon would be pinhead-slide. Is the URL in this PR not stable?

This works if an icon is in the root directory, but for baby it would have to be pinhead-people/baby which is unnecessarily verbose and might change in the future.

Though I am surprised that this link is unstable

This is intentional, mainly to enforce abstraction between the source files and the distributed files. E.g. icons can easily be recategorized in subdirectories to aid with navigation. The whole build pipeline could be refactored in the future if needed. This is more complex than most icon repos which are just a bucket of files, but I think it's helpful given Pinhead already has nearly 2,000 icons and growing.

also big thanks for this icon set! I only started exploring it and I found some useful icons already

I'm glad to hear it! Feel free to open issues if anything is missing or inconsistent.

@matkoniecz
Copy link
Copy Markdown
Contributor Author

But https://pinhead.ink/latest/baby.svg will be resistant to categorisation changes etc, right?

Obviously icon content can change if it will be updated and icon name can potentially change.

@matkoniecz
Copy link
Copy Markdown
Contributor Author

matkoniecz commented May 14, 2026

I'm glad to hear it! Feel free to open issues if anything is missing or inconsistent.

I will likely do this, thanks for invitation. (Roentgen project added some icons that become used in iD presets as soon as released and I have somewhere list of further missing icons... I will see what is missing also from the current Pinhead)

@matkoniecz matkoniecz marked this pull request as draft May 14, 2026 18:29
@matkoniecz
Copy link
Copy Markdown
Contributor Author

Converting to draft as the current icon sourcing is not recommended and new one requires some work to be done upstream

@quincylvania
Copy link
Copy Markdown
Contributor

Okay I added the /latest/ endpoints so now you can reference files like: https://pinhead.ink/latest/taco.svg

But https://pinhead.ink/latest/baby.svg will be resistant to categorisation changes etc, right?

Right, these endpoints should never 404. Even in the rare case an icon is renamed then the old name will continue to point to the same icon (but it will not receive any design updates).

@matkoniecz matkoniecz marked this pull request as ready for review May 14, 2026 23:16
@tyrasd tyrasd assigned tyrasd and unassigned tyrasd May 19, 2026
@tyrasd tyrasd added documentation Improvements or additions to documentation breaking icons labels May 19, 2026
@tyrasd tyrasd merged commit f8bb73f into ideditor:main May 19, 2026
2 checks passed
@matkoniecz matkoniecz deleted the pinhead branch May 19, 2026 09:59
@matkoniecz
Copy link
Copy Markdown
Contributor Author

matkoniecz commented May 19, 2026

@quincylvania I am quite excited about possibility to use (soon) Pinhead icons in all these editors :)

Thanks for making that collection!

@quincylvania
Copy link
Copy Markdown
Contributor

@matkoniecz Thanks for integrating! Excited to see Pinhead in more places.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

breaking documentation Improvements or additions to documentation icons

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Allow Pinhead as source for logos

4 participants