fix "size" drag force #353
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
not properly computed)
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a bug in the calculation of the sound speed for "size" drag force modeling when using an adiabatic equation of state. The issue was an incorrect placement of a closing parenthesis in the GetGamma function call, which was causing the density argument to be multiplied by the pressure-to-density ratio instead of being passed as a separate parameter.
Key Changes
- Corrected the parenthesis placement in the
GetGammafunction call to ensure proper argument passing - The sound speed calculation now correctly computes
sqrt(gamma * P / rho)instead of the previous incorrect formulation
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
This was referenced Oct 18, 2025
Merged
glesur
added a commit
that referenced
this pull request
Oct 19, 2025
## [2.2.02] 2025-10-18 ### Changed - Added a module to add explicit units (#338) - fixed a bug that could lead to incorrect profiling information on non-blocking cuda loops (#341) - fixed a bug that could lead to incorrect energy budget when shearing box and fargo were both enabled (#346) - fixed a bug that led to incorrect BX2 reconstruction when axis is not used on both sides of the domain (#345) - fixed a bug that led to incorrect reflective boundary conditions on B when DIMENSIONS < 3 (#345) - fixed a bug that led to incorrect dust stopping time when the adiabatic equation of state is used with "size" drag law (#353) ### Added - documentation for the continuous integration (#354) --------- Co-authored-by: Victor Réville <victorreville@gmail.com> Co-authored-by: Hal Bal <vreville@irap.omp.eu> Co-authored-by: Jean Kempf <jean.kempf@irap.omp.eu> Co-authored-by: Victor Réville <47865059+vreville@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #352
The "size" drag force, used notably for modeling dust grains, was not computed correctly when an adiabatic equation of state was used (the sound speed was not properly computed). This PR fixes this issue.
NB: this does not affect results when using a "userdef" drag force, or when using a "ISOTHERMAL" equation of state.