Skip to content

Fix correctness issues in skills, hooks, and dependency checks#10

Merged
samuelduchesne merged 1 commit into
mainfrom
claude/energyplus-plugin-skills-review-y3bzm
May 27, 2026
Merged

Fix correctness issues in skills, hooks, and dependency checks#10
samuelduchesne merged 1 commit into
mainfrom
claude/energyplus-plugin-skills-review-y3bzm

Conversation

@samuelduchesne
Copy link
Copy Markdown
Contributor

Address shortcomings found in an expert review of the plugin's skills:

  • upgrade-version: rewrite around the migrate_model tool (official
    IDFVersionUpdater transition chain) instead of hand-copying objects into
    a new_model, which silently corrupts models across version field/default
    changes. Add forward-only guard and EnergyPlus precondition.
  • inject-idf-context.sh: emit PreToolUse hookSpecificOutput.additionalContext
    JSON so the guidance actually reaches the model (plain stdout is ignored on
    PreToolUse); parse file_path via jq; drop the nonexistent get_object tool.
  • simulate / quick-sim: add the design-day sizing gate before annual runs and
    correct the unmet-hours criterion to ASHRAE 90.1 G3.1.2.3 (<=300 occupied
    hours each for heating and cooling, not a summed total).
  • validate: replace the fabricated Critical/Reference/Warning/Info taxonomy
    with the real ValidationResult shape (ERROR/WARNING/INFO + E0xx/W0xx codes).
  • new-model: note new_model seeds only four objects; add required Timestep,
    RunPeriod, Site:Location, infiltration, thermostats, and sizing objects.
  • idf-conventions / energy-modeler: drop stale hardcoded tool/resource counts
    and version pins in favor of the live tool surface; fix the vertex example
    to the structured vertices array.
  • check-deps.sh: select the newest EnergyPlus install via sort -V instead of
    the lexically-last glob match.
  • developing-with-idfkit: use the ${CLAUDE_SKILL_DIR} token so the command
    matches the allowed-tools permission pattern.

https://claude.ai/code/session_01MvFYZxrFeVbiTfnvBVgNRr

Address shortcomings found in an expert review of the plugin's skills:

- upgrade-version: rewrite around the migrate_model tool (official
  IDFVersionUpdater transition chain) instead of hand-copying objects into
  a new_model, which silently corrupts models across version field/default
  changes. Add forward-only guard and EnergyPlus precondition.
- inject-idf-context.sh: emit PreToolUse hookSpecificOutput.additionalContext
  JSON so the guidance actually reaches the model (plain stdout is ignored on
  PreToolUse); parse file_path via jq; drop the nonexistent get_object tool.
- simulate / quick-sim: add the design-day sizing gate before annual runs and
  correct the unmet-hours criterion to ASHRAE 90.1 G3.1.2.3 (<=300 occupied
  hours each for heating and cooling, not a summed total).
- validate: replace the fabricated Critical/Reference/Warning/Info taxonomy
  with the real ValidationResult shape (ERROR/WARNING/INFO + E0xx/W0xx codes).
- new-model: note new_model seeds only four objects; add required Timestep,
  RunPeriod, Site:Location, infiltration, thermostats, and sizing objects.
- idf-conventions / energy-modeler: drop stale hardcoded tool/resource counts
  and version pins in favor of the live tool surface; fix the vertex example
  to the structured vertices array.
- check-deps.sh: select the newest EnergyPlus install via sort -V instead of
  the lexically-last glob match.
- developing-with-idfkit: use the ${CLAUDE_SKILL_DIR} token so the command
  matches the allowed-tools permission pattern.

https://claude.ai/code/session_01MvFYZxrFeVbiTfnvBVgNRr
@samuelduchesne samuelduchesne merged commit b2fd768 into main May 27, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants