Add CI workflow to run discovery tests#3
Merged
Conversation
Runs tests/discovery/test_discover.py on push to main and on pull requests, across Python 3.10/3.13 and Ubuntu/Windows (the discovery logic has cross-platform paths). Stdlib-only, so no dependency install step. https://claude.ai/code/session_0121EsSJYijy1gbqZSJ1xFxv
Two assertions compared str(Path(...)) against forward-slash literals (["/v/bin/python"]), which fail on Windows where Path renders with backslashes — the cause of the Windows CI failures. Compute the expected value the same way the code does, and exercise filesystem behavior against real temp directories instead of patching pathlib.Path.is_file, so the path-detection tests are correct and identical across POSIX and Windows. https://claude.ai/code/session_0121EsSJYijy1gbqZSJ1xFxv
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a GitHub Actions workflow so the discovery contract is guarded automatically — previously the
tests/discovery/test_discover.pysuite (added in #2) only ran locally.python -m unittest tests.discovery.test_discoveron push tomainand on every PR.discover.pyhas cross-platform interpreter-path logic (bin/pythonvsScripts/python.exe).Test plan
python -m unittest tests.discovery.test_discover— 12 passed locally.https://claude.ai/code/session_0121EsSJYijy1gbqZSJ1xFxv
Generated by Claude Code