fix: use squeue as primary job status source over sacct - #25
Merged
Conversation
Coverage report
Click to see where and how coverage changed
This report was generated by python-coverage-comment-action |
||||||||||||||||||||||||
183amir
force-pushed
the
fix/scontrol-first-status
branch
from
March 16, 2026 15:07
12cd2b6 to
2c923a2
Compare
183amir
changed the title
183amir
force-pushed
the
fix/scontrol-first-status
branch
from
March 16, 2026 15:12
2c923a2 to
c03664f
Compare
Yannick-Dayer
previously approved these changes
Mar 16, 2026
sacct has a delay after job resubmission, showing stale state. squeue queries live Slurm state in a single batched call and is always up-to-date. Falls back to sacct for finished jobs, then scontrol as last resort. Works with all Slurm versions including old ones (tested on 20.11.4). Also updates pixi to v0.65.0 in CI. Closes #17 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
183amir
force-pushed
the
fix/scontrol-first-status
branch
from
March 16, 2026 15:52
c03664f to
b441159
Compare
Collaborator
Author
|
@Yannick-Dayer could you please review again? There were conflicts with #24 that I fixed nothing was changed. |
Yannick-Dayer
approved these changes
Mar 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
squeue(live Slurm state) as primary source for job status instead ofsacctsqueuecall for all jobs — efficient even with many jobssacctfor finished jobs no longer in Slurm's active memory, thenscontrolas last resortscontrolcomma-separated IDs are not supported)Closes #17
🤖 Generated with Claude Code
📚 Documentation preview 📚: https://gridtk--25.org.readthedocs.build/en/25/