Skip to content

fix save settings#97

Merged
idlesign merged 1 commit intoidlesign:masterfrom
mgefimov:master
May 9, 2026
Merged

fix save settings#97
idlesign merged 1 commit intoidlesign:masterfrom
mgefimov:master

Conversation

@mgefimov
Copy link
Copy Markdown
Contributor

@mgefimov mgefimov commented May 9, 2026

WithSettings.save_settings introspects __init__ to discover setting names,
but only looked at getfullargspec(...).args. After dcfb454#diff-b78b80c1401f36ffbc9ab4e51d9bdc3e6c5cec943c3031f2eb3788d35f368bbaR463 GenericPrivateTracker migrated
to keyword-only signatures, so the saved settings dict was always {}

Fix: include spec.kwonlyargs alongside spec.args[1:]

before

before

after
after

@coveralls
Copy link
Copy Markdown

coveralls commented May 9, 2026

Coverage Report for CI Build 25593672514

Coverage remained the same at 67.675%

Details

  • Coverage remained the same as the base build.
  • Patch coverage: 2 of 2 lines across 1 file are fully covered (100%).
  • No coverage regressions found.

Uncovered Changes

No uncovered changes found.

Coverage Regressions

No coverage regressions found.


Coverage Stats

Coverage Status
Relevant Lines: 1686
Covered Lines: 1141
Line Coverage: 67.67%
Coverage Strength: 3.85 hits per line

💛 - Coveralls

@idlesign idlesign merged commit 0d9071f into idlesign:master May 9, 2026
7 checks passed
@idlesign
Copy link
Copy Markdown
Owner

idlesign commented May 9, 2026

Thank you. Merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants