Introduce parallel runs #129

ckittl · 2022-01-13T13:55:48Z

Resolves #128

Co-authored-by: johanneshiry <johannes.hiry@tu-dortmund.de>

codecov · 2022-01-14T07:50:32Z

Codecov Report

Merging #129 (f9d7b7f) into dev (6b1605b) will not change coverage.
The diff coverage is n/a.

❗ Current head f9d7b7f differs from pull request most recent head 551ffad. Consider uploading reports for the commit 551ffad to get more accurate results

@@          Coverage Diff          @@
##             dev    #129   +/-   ##
=====================================
  Coverage   0.00%   0.00%           
=====================================
  Files         25      25           
  Lines       1512    1512           
  Branches     236     236           
=====================================
  Misses      1512    1512

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2f65c45...551ffad. Read the comment docs.

ckittl · 2022-01-14T07:54:02Z

@johanneshiry Please double check, if I took over your implementations correctly.

t-ober

Some clarification questions and minor remarks.

Also: What about tests? Since I'm not too familiar with Akka they would make me feel better that this stuff works as expected. 🙄

src/main/scala/edu/ie3/osmogrid/guardian/OsmoGridGuardian.scala

src/main/scala/edu/ie3/osmogrid/cfg/ConfigFailFast.scala

t-ober · 2022-01-17T13:08:53Z

src/main/scala/edu/ie3/osmogrid/guardian/OsmoGridGuardian.scala

+        idle(stopRunProcesses(guardianData, watch.runId, ctx))
+      case (ctx, unsupported) =>
+        ctx.log.error(s"Received unsupported message '$unsupported'.")
+        Behaviors.stopped


As of discussion: Check if a useful message is sent to the children.

Also the error message should include that we shut down the children and the guardian.

Thanks to sealed trait Request, that case is unreachable, anyway.

src/main/scala/edu/ie3/osmogrid/guardian/RunSupport.scala

t-ober · 2022-01-17T13:46:37Z

src/main/scala/edu/ie3/osmogrid/guardian/SubGridHandling.scala

+  private def assignSubnetNumber(subGrid: SubGridContainer, subnetNumber: Int) =
+    subGrid
+}


I don't think this is what we want 😂

Oh yes... If you forget to improve your own dummy implementation. ^^

Well... To not blow up this PR too much, I would like to hand this in as a separate PR (cf. #131).

src/main/scala/edu/ie3/osmogrid/lv/LvCoordinator.scala

for InputDataProvider and ResultListener

src/main/scala/edu/ie3/osmogrid/cfg/ConfigFailFast.scala

src/main/scala/edu/ie3/osmogrid/guardian/run/package.scala

…rid into ck/#128-parallelRuns

johanneshiry

Thanks for your work. Please consider my remarks and let me know if there is anything to discuss about. :)

src/main/scala/edu/ie3/osmogrid/cfg/ConfigFailFast.scala

src/main/scala/edu/ie3/osmogrid/guardian/run/RunGuardian.scala

src/main/scala/edu/ie3/osmogrid/guardian/run/RunSupport.scala

src/main/scala/edu/ie3/osmogrid/guardian/run/RunGuardian.scala

src/main/scala/edu/ie3/osmogrid/lv/LvCoordinator.scala

src/main/scala/edu/ie3/osmogrid/lv/LvRegionCoordinator.scala

johanneshiry · 2022-01-28T15:06:18Z

!test

sonarqubegithubprchecks · 2022-01-28T15:08:38Z

Analysis Details

3 Issues

0 Bugs
0 Vulnerabilities
3 Code Smells

Coverage and Duplications

No coverage information (0.00% Estimated after merge)
0.00% Duplicated Code (0.00% Estimated after merge)

Project ID: edu.ie3:OSMoGrid

View in SonarQube

johanneshiry

LGTM. Thank you! Wish you an amazing weekend! 🎖️

Adapt message structure

db653f8

ckittl added the enhancement New feature or request label Jan 13, 2022

ckittl added this to the Version 1.0 milestone Jan 13, 2022

ckittl self-assigned this Jan 13, 2022

This was referenced Jan 13, 2022

Lv Coordinator according to updated concept #121

Merged

Implement result event listener #116

Merged

This comment has been minimized.

Sign in to view

ckittl and others added 8 commits January 13, 2022 17:01

Add support for run id

9e2799f

Add actor data and run meta data

355ce4e

Co-authored-by: johanneshiry <johannes.hiry@tu-dortmund.de>

Initiate a run and register its meta information

1f524bf

Co-authored-by: johanneshiry <johannes.hiry@tu-dortmund.de>

Refactoring run init process

686b2b4

Handle death watch events

20529ea

Co-authored-by: johanneshiry <johannes.hiry@tu-dortmund.de>

Handle incoming results

f039d1b

Address successful result handling

e564e71

Fix broken test

a4bb7de

This comment has been minimized.

Sign in to view

ckittl marked this pull request as ready for review January 14, 2022 07:50

ckittl requested review from a team and johanneshiry January 14, 2022 07:53

t-ober requested changes Jan 17, 2022

View reviewed changes

ckittl added 5 commits January 17, 2022 16:59

Addressing reviewer's comments

8a5f153

Post stop phase

8186d5e

for InputDataProvider and ResultListener

Introduce coordinated shut down phase

c0b6cbe

Only terminate internal result listener

b6b55bf

Fix failing test

f9d7b7f

ckittl mentioned this pull request Jan 18, 2022

Implement sub grid collection logic #131

Closed

This comment has been minimized.

Sign in to view

Ignore incoming results for runs in shutdown phase

8a34512

Test receiving results

056caa0

This comment has been minimized.

Sign in to view

Adding tests for RunGuardian.stopping

67254c6

This comment has been minimized.

Sign in to view

ckittl requested review from johanneshiry and t-ober January 24, 2022 14:47

Preempting @johanneshiry's review comment

b8a54e7

This comment has been minimized.

Sign in to view

Merge branch 'dev' into ck/#128-parallelRuns

ca66643

This comment has been minimized.

Sign in to view

Merge branch 'dev' into ck/#128-parallelRuns

e0d0f65

This comment has been minimized.

Sign in to view

johanneshiry reviewed Jan 27, 2022

View reviewed changes

src/main/scala/edu/ie3/osmogrid/cfg/ConfigFailFast.scala Outdated Show resolved Hide resolved

src/main/scala/edu/ie3/osmogrid/cfg/ConfigFailFast.scala Outdated Show resolved Hide resolved

src/main/scala/edu/ie3/osmogrid/guardian/run/package.scala Outdated Show resolved Hide resolved

ckittl added 3 commits January 27, 2022 11:31

Get rid of package objects

c72c26c

Address reviewer's comments

036e874

Merge branch 'ck/#128-parallelRuns' of github.com:ie3-institute/osmog…

6770ee1

…rid into ck/#128-parallelRuns

This comment has been minimized.

Sign in to view

ckittl requested a review from johanneshiry January 27, 2022 11:03

Making death watch events public

6c0807b

This comment has been minimized.

Sign in to view

johanneshiry requested changes Jan 27, 2022

View reviewed changes

Addressing reviewer's comments

551ffad

This comment has been minimized.

Sign in to view

ckittl requested a review from johanneshiry January 27, 2022 16:48

johanneshiry approved these changes Jan 28, 2022

View reviewed changes

t-ober approved these changes Jan 28, 2022

View reviewed changes

t-ober merged commit 227815a into dev Jan 28, 2022

t-ober deleted the ck/#128-parallelRuns branch January 28, 2022 15:40

Introduce parallel runs #129

Introduce parallel runs #129

Uh oh!

Conversation

ckittl commented Jan 13, 2022

Uh oh!

This comment has been minimized.

This comment has been minimized.

codecov bot commented Jan 14, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

ckittl commented Jan 14, 2022

Uh oh!

t-ober left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

t-ober Jan 17, 2022

Choose a reason for hiding this comment

Uh oh!

ckittl Jan 17, 2022

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

t-ober Jan 17, 2022

Choose a reason for hiding this comment

Uh oh!

ckittl Jan 17, 2022

Choose a reason for hiding this comment

Uh oh!

ckittl Jan 18, 2022

Choose a reason for hiding this comment

Uh oh!

Uh oh!

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

Uh oh!

Uh oh!

Uh oh!

This comment has been minimized.

This comment has been minimized.

johanneshiry left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

This comment has been minimized.

johanneshiry commented Jan 28, 2022

Uh oh!

sonarqubegithubprchecks bot commented Jan 28, 2022

Analysis Details

3 Issues

Coverage and Duplications

Uh oh!

johanneshiry left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

codecov bot commented Jan 14, 2022 •

edited

Loading