LL/#73 first implementation of input #98

larslenssen · 2021-12-03T12:19:36Z

No description provided.

add osm4scala

#73-firstImplementationOfInput

codecov · 2021-12-03T12:32:15Z

Codecov Report

Merging #98 (a230e94) into dev (f9d7b7f) will not change coverage.
The diff coverage is n/a.

❗ Current head a230e94 differs from pull request most recent head 2c226fd. Consider uploading reports for the commit 2c226fd to get more accurate results

@@          Coverage Diff          @@
##             dev     #98   +/-   ##
=====================================
  Coverage   0.00%   0.00%           
=====================================
  Files         25      25           
  Lines       1512    1512           
  Branches     236     236           
=====================================
  Misses      1512    1512

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fed96cc...2c226fd. Read the comment docs.

…tionOfInput

src/main/scala/edu/ie3/osmogrid/io/input/InputDataProvider.scala

…tionOfInput

commit review suggestions Co-authored-by: Chris Kittl <44838605+ckittl@users.noreply.github.com>

Add OsmoGridModel as extension of OsmModel

johanneshiry · 2022-01-03T08:48:11Z

Please resolve PSU#193 first

johanneshiry · 2022-01-03T09:03:57Z

Sonarqube fails as it seems that the currently used version does not recognize enums in scala 3 correctly. Please ignore this for now in your review. Will fix this asap.

…ix input actor for new osmModel

src/main/scala/edu/ie3/osmogrid/io/input/InputDataProvider.scala

ckittl

Thanks once again for your work! I think there is one or the other question, that needs clarification.

src/main/scala/edu/ie3/osmogrid/io/input/InputDataProvider.scala

src/main/scala/edu/ie3/osmogrid/io/input/OsmSource.scala

src/main/scala/edu/ie3/osmogrid/io/input/pbf/PbfGuardian.scala

src/main/scala/edu/ie3/osmogrid/io/input/pbf/PbfWorker.scala

src/test/scala/edu/ie3/osmogrid/io/input/OsmSourceSpec.scala

Co-authored-by: Chris Kittl <44838605+ckittl@users.noreply.github.com>

ckittl

Only smaller remarks, other than that it looks pretty good! 🌞 Thanks!

src/main/scala/edu/ie3/osmogrid/ActorStopSupport.scala

ckittl · 2022-03-25T09:02:31Z

src/main/scala/edu/ie3/osmogrid/ActorStopSupportStateless.scala

+  * @tparam T
+  *   Behavior type
+  */
+trait ActorStopSupportStateless[T] {


Why did you decide to not extend the existing trait and override the methods? The traits are meant to do the same thing, but have different outline (cf. cleanUp is once a partial function and once a method)

I now adapted the interface definitions to match types as far as possible (both using functions now)

src/main/scala/edu/ie3/osmogrid/io/input/InputDataProvider.scala

…efinitions

sonarqubegithubprchecks · 2022-03-27T22:33:51Z

Analysis Details

0 Issues

0 Bugs
0 Vulnerabilities
0 Code Smells

Coverage and Duplications

No coverage information (0.00% Estimated after merge)
0.00% Duplicated Code (0.00% Estimated after merge)

Project ID: edu.ie3:OSMoGrid

View in SonarQube

larslenssen added 8 commits December 3, 2021 10:34

change to PowerSystemUtils:1.6-SNAPSHOT

165b9d2

add osm4scala

Add Pattern Interaction to InputDataProvider.scala

df6d8f7

Add Init(cfg) Reply

514d8b9

Add ReqOsm() for simple osm reading

f9acab0

add readPbf() as input channel pbf, without filters

a196dd7

Convert pbf to OsmModel (only Nodes atm)

8abb1ba

Merge branch 'dev' of https://github.com/ie3-institute/OSMoGrid into ll/

7c8592b

#73-firstImplementationOfInput

scala spotless apply

ad31666

add convert pbf -> OsmModel way

5ab597a

larslenssen linked an issue Dec 3, 2021 that may be closed by this pull request

Implement Input Actor #73

Closed

5 tasks

ckittl added 2 commits December 7, 2021 16:48

Merge remote-tracking branch 'origin/dev' into ll/#73-firstImplementa…

c7f6eb6

…tionOfInput

Fix merge

3db4dcf

ckittl requested changes Dec 7, 2021

View reviewed changes

ckittl and others added 12 commits December 8, 2021 12:03

Merge remote-tracking branch 'origin/dev' into ll/#73-firstImplementa…

a230e94

…tionOfInput

Apply suggestions from code review

f5e41ae

commit review suggestions Co-authored-by: Chris Kittl <44838605+ckittl@users.noreply.github.com>

Fix code suggestions + scalaDoc

fb7427d

Add simple filter for readPBF

ff3d771

Add OsmoGridModel as extension of OsmModel

Merge branch 'dev' into ll/#73-firstImplementationOfInput

7bf8498

moved OsmoGridModel to proper package

39c1902

proper naming of required tags in InputDataProvider

02aa4d1

first implementation of concurrent pbf file source

f341dd6

add spotless support for scala 3

cc6ef75

improved concurrent pbf file source + config filter support

7079a9f

improved LvOsmoGridModel creation by node filtering

3f5db04

Merge branch 'dev' into ll/#73-firstImplementationOfInput

bbcb30a

Merge 'remotes/origin/dev' into ll/#73-firstImplementationOfInput + f…

cb6156e

…ix input actor for new osmModel

ckittl requested changes Jan 31, 2022

View reviewed changes

src/main/scala/edu/ie3/osmogrid/io/input/InputDataProvider.scala Outdated Show resolved Hide resolved

src/main/scala/edu/ie3/osmogrid/io/input/InputDataProvider.scala Outdated Show resolved Hide resolved

src/main/scala/edu/ie3/osmogrid/io/input/InputDataProvider.scala Show resolved Hide resolved

This comment has been minimized.

Sign in to view

ckittl requested changes Mar 14, 2022

View reviewed changes

ckittl mentioned this pull request Mar 14, 2022

Fix read status message generation #156

Open

sebastian-peter and others added 10 commits March 14, 2022 11:16

Introducing stateful ActorStopSupport

f7d7342

Tracking pbfs with lfs and renaming test map data

5217067

Another round of addressing reviewers' comments

caa6a0e

Update src/main/scala/edu/ie3/osmogrid/io/input/OsmSource.scala

6670397

Co-authored-by: Chris Kittl <44838605+ckittl@users.noreply.github.com>

Testing with longer timeout

6841b35

Capturing logs during tests

cd2d87e

Reacting to failed reads in OsmSourceSpec

161191b

Deleting unused file

4c2237d

Enabling LFS in Jenkins

9b713f7

Removing LFS again

5cdb996

sebastian-peter requested a review from ckittl March 14, 2022 14:33

This comment has been minimized.

Sign in to view

Implementing integration test for InputDataProvider

8bf85c3

sebastian-peter force-pushed the ll/#73-firstImplementationOfInput branch from 5ac518e to 8bf85c3 Compare March 21, 2022 13:47

This comment has been minimized.

Sign in to view

ckittl requested changes Mar 25, 2022

View reviewed changes

ckittl added 2 commits March 25, 2022 10:24

Merge branch 'dev' into ll/#73-firstImplementationOfInput

19696e8

Merge branch 'dev' into ll/#73-firstImplementationOfInput

c63cbe7

This comment has been minimized.

Sign in to view

Addressing reviewer comment: harmonizing ActorStopSupport interface d…

2c226fd

…efinitions

sebastian-peter requested review from ckittl and t-ober March 27, 2022 22:32

ckittl approved these changes Mar 28, 2022

View reviewed changes

sebastian-peter merged commit 8e8d011 into dev Mar 28, 2022

sebastian-peter deleted the ll/#73-firstImplementationOfInput branch March 28, 2022 07:56

LL/#73 first implementation of input #98

LL/#73 first implementation of input #98

Uh oh!

Conversation

larslenssen commented Dec 3, 2021

Uh oh!

codecov bot commented Dec 3, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

johanneshiry commented Jan 3, 2022

Uh oh!

johanneshiry commented Jan 3, 2022

Uh oh!

Uh oh!

Uh oh!

Uh oh!

This comment has been minimized.

ckittl left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

This comment has been minimized.

This comment has been minimized.

ckittl left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

ckittl Mar 25, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

sebastian-peter Mar 27, 2022

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

This comment has been minimized.

This comment has been minimized.

sonarqubegithubprchecks bot commented Mar 27, 2022

Analysis Details

0 Issues

Coverage and Duplications

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

codecov bot commented Dec 3, 2021 •

edited

Loading

ckittl Mar 25, 2022 •

edited

Loading