Implementing an evcs validation. #1003
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixing throwing exception for not yet implemented validations.
staudtMarius
added
bug
sebastian-peter
requested changes
Feb 4, 2024
Member
sebastian-peter
left a comment
sebastian-peter
left a comment
There was a problem hiding this comment.
Looks all good from my side, just some minor syntactic points here
src/main/java/edu/ie3/datamodel/utils/validation/SystemParticipantValidationUtils.java
Outdated
Show resolved
Hide resolved
src/main/java/edu/ie3/datamodel/utils/validation/SystemParticipantValidationUtils.java
Outdated
Show resolved
Hide resolved
src/main/java/edu/ie3/datamodel/utils/validation/SystemParticipantValidationUtils.java
Outdated
Show resolved
Hide resolved
sebastian-peter
approved these changes
Feb 6, 2024
Member
sebastian-peter
left a comment
sebastian-peter
left a comment
There was a problem hiding this comment.
@staudtMarius I fixed some minor errors (if you're curious, check here) and now it looks good to go!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #879
Resolves #1000