Replaced LoadProfileInput with LoadProfileTimeSeries
#1229
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danielfeismann
requested changes
Feb 4, 2025
Member
danielfeismann
left a comment
danielfeismann
left a comment
There was a problem hiding this comment.
Having some questions and I'm not sure if I got the reason for these changes. Maybe we can have a talk the next days to get me on the same level, thanks :)
src/main/java/edu/ie3/datamodel/io/naming/EntityPersistenceNamingStrategy.java
Show resolved
Hide resolved
src/main/java/edu/ie3/datamodel/models/timeseries/repetitive/LoadProfileEntry.java
Show resolved
Hide resolved
src/main/java/edu/ie3/datamodel/models/timeseries/repetitive/RepetitiveTimeSeries.java
Outdated
Show resolved
Hide resolved
# Conflicts: # CHANGELOG.md
Member
danielfeismann
left a comment
danielfeismann
left a comment
There was a problem hiding this comment.
LGTM so far, thanks for checking my questions. Could you please have a look to the sonarQube issues and then where are good to go from my side
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #1228