Add Attributes housingType and numberInhabitants to ThermalHouses #1254
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danielfeismann
added
enhancement
# Conflicts: # CHANGELOG.md
staudtMarius
requested changes
Feb 21, 2025
Member
staudtMarius
left a comment
staudtMarius
left a comment
There was a problem hiding this comment.
Just some small remarks.
src/main/java/edu/ie3/datamodel/models/input/thermal/ThermalHouseInput.java
Outdated
Show resolved
Hide resolved
src/test/groovy/edu/ie3/datamodel/io/factory/input/ThermalHouseInputFactoryTest.groovy
Outdated
Show resolved
Hide resolved
src/test/groovy/edu/ie3/datamodel/models/input/thermal/ThermalHouseInputTest.groovy
Show resolved
Hide resolved
staudtMarius
requested changes
Feb 21, 2025
Member
staudtMarius
left a comment
staudtMarius
left a comment
There was a problem hiding this comment.
Some more small remarks.
src/main/java/edu/ie3/datamodel/models/input/thermal/ThermalHouseInput.java
Outdated
Show resolved
Hide resolved
src/test/resources/edu/ie3/datamodel/io/sink/_sql/input_entities.sql
Outdated
Show resolved
Hide resolved
src/main/java/edu/ie3/datamodel/io/factory/input/ThermalHouseInputFactory.java
Show resolved
Hide resolved
staudtMarius
approved these changes
Feb 24, 2025
Member
staudtMarius
left a comment
staudtMarius
left a comment
There was a problem hiding this comment.
LGTM, thanks for your work.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #1253