Skip to content

Fix CosmoTimeBasedWeatherValueFactoryTest #1470

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 5 commits into
base: dev
Choose a base branch
from
Open

Fix CosmoTimeBasedWeatherValueFactoryTest #1470

wants to merge 5 commits into from

Conversation

@danielfeismann
Copy link
Member

@danielfeismann danielfeismann commented Nov 3, 2025 •
edited
Loading

resolves #1469

@danielfeismann danielfeismann self-assigned this Nov 3, 2025
@danielfeismann danielfeismann added bug Something isn't working test Related to tests labels Nov 3, 2025
@danielfeismann danielfeismann added this to the Version 8.2 milestone Nov 3, 2025
@danielfeismann danielfeismann mentioned this pull request Nov 3, 2025
Open
@danielfeismann danielfeismann marked this pull request as ready for review November 4, 2025 14:45
@danielfeismann
Copy link
Member Author

danielfeismann commented Nov 4, 2025

To reviewer: It looks to me like when testing model == exptectedResults the test does not use the correct equals method (of TimeBasedValue) but the general Object.equals(). Maybe there is a better solution as my current workaround.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sebastian-peter sebastian-peter Awaiting requested review from sebastian-peter

@staudtMarius staudtMarius Awaiting requested review from staudtMarius

At least 1 approving review is required to merge this pull request.

Assignees

@danielfeismann danielfeismann

Labels

bug Something isn't working test Related to tests

Projects

None yet

Milestone

Version 8.2

Development

Successfully merging this pull request may close these issues.

CosmoTimeBasedWeatherValueFactoryTest does not work properly

2 participants

@danielfeismann