Skip to content

Conversation

@t-ober
Copy link
Contributor

@t-ober t-ober commented Feb 11, 2022

Resolves #529

@t-ober t-ober added the bug Something isn't working label Feb 11, 2022
@t-ober t-ober requested a review from a team February 11, 2022 11:01
@sonarqubegithubprchecks

This comment has been minimized.

Copy link
Member

@johanneshiry johanneshiry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix as discussed + also adapt the issue title and description. Thank you! :)

@t-ober t-ober marked this pull request as draft February 11, 2022 12:35
@t-ober t-ober requested a review from johanneshiry February 11, 2022 12:50
@t-ober t-ober marked this pull request as ready for review February 11, 2022 12:50
@sonarqubegithubprchecks

This comment has been minimized.

@codecov
Copy link

codecov bot commented Feb 11, 2022

Codecov Report

Merging #530 (991bf2d) into dev (d67f11c) will decrease coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##                dev     #530      +/-   ##
============================================
- Coverage     77.70%   77.67%   -0.03%     
+ Complexity     2138     2134       -4     
============================================
  Files           271      271              
  Lines          8463     8461       -2     
  Branches        805      805              
============================================
- Hits           6576     6572       -4     
- Misses         1487     1493       +6     
+ Partials        400      396       -4     
Impacted Files Coverage Δ
...du/ie3/datamodel/io/source/IdCoordinateSource.java 80.00% <0.00%> (-5.72%) ⬇️
...tamodel/models/input/system/type/ChpTypeInput.java 72.00% <0.00%> (-4.00%) ⬇️
...e3/datamodel/models/input/connector/LineInput.java 75.43% <0.00%> (-1.76%) ⬇️
.../models/input/thermal/CylindricalStorageInput.java 86.66% <0.00%> (-1.67%) ⬇️
...atamodel/models/input/system/type/EvTypeInput.java 77.77% <0.00%> (ø)
...tamodel/models/input/system/type/WecTypeInput.java 72.00% <0.00%> (ø)
...s/input/connector/type/Transformer3WTypeInput.java 73.52% <0.00%> (+1.47%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8707ef1...991bf2d. Read the comment docs.

@sonarqubegithubprchecks

This comment has been minimized.

@sonarqubegithubprchecks

This comment has been minimized.

@sonarqubegithubprchecks

This comment has been minimized.

@sonarqubegithubprchecks

This comment has been minimized.

@sonarqubegithubprchecks

This comment has been minimized.

@sonarqubegithubprchecks

This comment has been minimized.

@sonarqubegithubprchecks
Copy link

Passed

Analysis Details

0 Issues

  • Bug0 Bugs
  • Vulnerability0 Vulnerabilities
  • Code Smell0 Code Smells

Coverage and Duplications

  • 60 percent coverage66.67% Coverage (77.00% Estimated after merge)
  • 3 percent duplication0.00% Duplicated Code (0.40% Estimated after merge)

Project ID: edu.ie3:PowerSystemDataModel

View in SonarQube

@johanneshiry johanneshiry merged commit 657d038 into dev Mar 7, 2022
@johanneshiry johanneshiry deleted the to/#529-get-nearest-coordinates branch March 7, 2022 11:35
@sebastian-peter sebastian-peter added this to the Version 3.0 milestone Jan 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Adapt IdCoordinateSource.getNearestCoordinates to explicitly use all coordinates

5 participants