Deleted parameter decimalPlaces #714
Conversation
vickybung1
requested review from
danielfeismann,
jo-bao,
sebastian-peter and
t-ober
![sonatype-lift[bot]](https://avatars.githubusercontent.com/in/9843?s=60&v=4){kind=small}
src/main/java/edu/ie3/datamodel/models/input/system/characteristic/CharacteristicInput.java
Outdated
Show resolved
Hide resolved
sebastian-peter
left a comment
sebastian-peter
left a comment
There was a problem hiding this comment.
From my side, this looks all good. Don't know if you discussed any other steps last week, @danielfeismann ?
The minor point I made here could be solved in a different PR.
src/main/java/edu/ie3/datamodel/models/input/system/characteristic/CharacteristicInput.java
Outdated
Show resolved
Hide resolved
sebastian-peter
left a comment
sebastian-peter
left a comment
There was a problem hiding this comment.
Additionally, there's CharacteristicDatamodelConcept.puml which needs some minor adaptations. In order to see the result, you need the PlantUML plugin for Intellij. Please let me know if I can assist with that.
src/main/java/edu/ie3/datamodel/models/input/system/characteristic/CharacteristicInput.java
Outdated
Show resolved
Hide resolved
src/main/java/edu/ie3/datamodel/models/input/system/characteristic/CharacteristicPoint.java
Outdated
Show resolved
Hide resolved
src/test/groovy/edu/ie3/datamodel/io/processor/input/InputEntityProcessorTest.groovy
Outdated
Show resolved
Hide resolved
sebastian-peter
left a comment
sebastian-peter
left a comment
There was a problem hiding this comment.
Thanks for fixing serialization-related documentation and naming in so many places! I think this is a good contribution towards making the PSDM more understandable.
Please check my remarks below. Also, please enhance the changelog message with something indicating that the naming of serialization methods has changed as well.
Resolves #710